Add UMA for CrossFadeAnimation.

Add UMA for CrossFadeAnimation.

Add one UMA for CrossFadeAnimation smoothness, used in maximize windows,
so that we can evaluate how much improvement we can achieve by forcing
use of render surface.

BUG=708513
TEST=has histogram at local device.

Review-Url: https://codereview.chromium.org/2869263002
Cr-Commit-Position: refs/heads/master@{#472191}
Committed: https://chromium.googlesource.com/chromium/src/+/883ea6f5b904ba890bf23ff0b76bd711f6f343f9

[wutao, 2017-05-10 00:29:43]

wutao@chromium.org changed reviewers:
+ varkha@chromium.org

[wutao, 2017-05-10 00:29:44]

Hi Valery, Please have a look first.

Add the UMA for maximizing animation first.

Thanks.
Tao

[wutao, 2017-05-11 22:24:44]

Hi varkha@, kindly ping.

Tao

[varkha, 2017-05-12 15:14:25]

lgtm with a nit.

https://codereview.chromium.org/2869263002/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

https://codereview.chromium.org/2869263002/diff/1/ash/wm/window_animations.cc...
ash/wm/window_animations.cc:89: class CrossFadeMetricsReporter : public
ui::AnimationMetricsReporter {
There was a nit in a previous similar CL to define public ctor/dtor, then
DISALLOW_COPY_AND_ASSIGN so I would keep those consistent.

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:2378: +    represents ideally smooth 60
frames per second. 50% represents only 30
nit: ...represents when only...

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:2380: +    This metric is recorded
exactly once when WmWindow::SetBoundsDirectCrossFade
WmWindow will be going away so maybe just "SetBoundsDirectCrossFade".

[wutao, 2017-05-12 17:46:37]

wutao@chromium.org changed reviewers:
+ holte@chromium.org, oshima@chromium.org

[wutao, 2017-05-12 17:46:38]

Hi varkha@, ptal.

Hi oshima@: Please review changes in 
ash/rotator/screen_rotation_animator.cc

Hi holte@, Please review changes in
tools/metrics/histograms/histograms.xml

Thanks.
Tao

https://codereview.chromium.org/2869263002/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

https://codereview.chromium.org/2869263002/diff/1/ash/wm/window_animations.cc...
ash/wm/window_animations.cc:89: class CrossFadeMetricsReporter : public
ui::AnimationMetricsReporter {
On 2017/05/12 15:14:25, varkha wrote:
> There was a nit in a previous similar CL to define public ctor/dtor, then
> DISALLOW_COPY_AND_ASSIGN so I would keep those consistent.

I kept copying from your first code. I will make change to that code too.

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:2378: +    represents ideally smooth 60
frames per second. 50% represents only 30
On 2017/05/12 15:14:25, varkha wrote:
> nit: ...represents when only...

Done.

https://codereview.chromium.org/2869263002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:2380: +    This metric is recorded
exactly once when WmWindow::SetBoundsDirectCrossFade
On 2017/05/12 15:14:25, varkha wrote:
> WmWindow will be going away so maybe just "SetBoundsDirectCrossFade".

Done.

[Steven Holte, 2017-05-13 00:56:38]

lgtm

[oshima, 2017-05-13 01:08:30]

lgtm

[wutao, 2017-05-13 01:33:30]

The CQ bit was checked by wutao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 01:34:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 02:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:54:29]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[wutao, 2017-05-13 03:58:43]

The CQ bit was checked by wutao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 03:58:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 05:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 05:47:16]

Dry run: This issue passed the CQ dry run.

[wutao, 2017-05-16 16:16:51]

The CQ bit was checked by wutao@chromium.org

[wutao, 2017-05-16 16:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org
Link to the patchset: https://codereview.chromium.org/2869263002/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2017-05-16 16:17:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:05:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wutao, 2017-05-16 18:18:22]

The CQ bit was checked by wutao@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:20:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:40:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494958702436530,
"parent_rev": "0c1b47cd5f45d567d8b1ea929ab2efd413045862", "commit_rev":
"883ea6f5b904ba890bf23ff0b76bd711f6f343f9"}

[commit-bot: I haz the power, 2017-05-16 19:41:09]

Description was changed from

==========
Add UMA for CrossFadeAnimation.

Add one UMA for CrossFadeAnimation smoothness, used in maximize windows,
so that we can evaluate how much improvement we can achieve by forcing
use of render surface.

BUG=708513
TEST=has histogram at local device.
==========

to

==========
Add UMA for CrossFadeAnimation.

Add one UMA for CrossFadeAnimation smoothness, used in maximize windows,
so that we can evaluate how much improvement we can achieve by forcing
use of render surface.

BUG=708513
TEST=has histogram at local device.

Review-Url: https://codereview.chromium.org/2869263002
Cr-Commit-Position: refs/heads/master@{#472191}
Committed:
https://chromium.googlesource.com/chromium/src/+/883ea6f5b904ba890bf23ff0b76b...
==========

[commit-bot: I haz the power, 2017-05-16 19:41:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/883ea6f5b904ba890bf23ff0b76b...