Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 nullptr) {} 76 nullptr) {}
77 77
78 ~MockPasswordProtectionService() override {} 78 ~MockPasswordProtectionService() override {}
79 79
80 MOCK_METHOD3(FillReferrerChain, 80 MOCK_METHOD3(FillReferrerChain,
81 void(const GURL&, 81 void(const GURL&,
82 int, 82 int,
83 safe_browsing::LoginReputationClientRequest::Frame*)); 83 safe_browsing::LoginReputationClientRequest::Frame*));
84 MOCK_METHOD0(IsExtendedReporting, bool()); 84 MOCK_METHOD0(IsExtendedReporting, bool());
85 MOCK_METHOD0(IsIncognito, bool()); 85 MOCK_METHOD0(IsIncognito, bool());
86 MOCK_METHOD1(IsPingingEnabled, bool(const base::Feature&)); 86 MOCK_METHOD2(IsPingingEnabled, bool(const base::Feature&, RequestOutcome*));
87 MOCK_METHOD0(IsHistorySyncEnabled, bool()); 87 MOCK_METHOD0(IsHistorySyncEnabled, bool());
88 MOCK_METHOD3(MaybeStartLowReputationRequest, 88 MOCK_METHOD3(MaybeStartPasswordFieldOnFocusRequest,
89 void(const GURL&, const GURL&, const GURL&)); 89 void(const GURL&, const GURL&, const GURL&));
90 90
91 private: 91 private:
92 DISALLOW_COPY_AND_ASSIGN(MockPasswordProtectionService); 92 DISALLOW_COPY_AND_ASSIGN(MockPasswordProtectionService);
93 }; 93 };
94 #endif 94 #endif
95 95
96 // TODO(vabr): Get rid of the mocked client in the client's own test, see 96 // TODO(vabr): Get rid of the mocked client in the client's own test, see
97 // http://crbug.com/474577. 97 // http://crbug.com/474577.
98 class MockChromePasswordManagerClient : public ChromePasswordManagerClient { 98 class MockChromePasswordManagerClient : public ChromePasswordManagerClient {
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 // CanShowBubbleOnURL currently only depends on the scheme. 603 // CanShowBubbleOnURL currently only depends on the scheme.
604 GURL url(base::StringPrintf("%s://example.org", test_case.scheme)); 604 GURL url(base::StringPrintf("%s://example.org", test_case.scheme));
605 SCOPED_TRACE(url.possibly_invalid_spec()); 605 SCOPED_TRACE(url.possibly_invalid_spec());
606 EXPECT_EQ(test_case.can_show_bubble, 606 EXPECT_EQ(test_case.can_show_bubble,
607 ChromePasswordManagerClient::CanShowBubbleOnURL(url)); 607 ChromePasswordManagerClient::CanShowBubbleOnURL(url));
608 } 608 }
609 } 609 }
610 610
611 #if defined(SAFE_BROWSING_DB_LOCAL) 611 #if defined(SAFE_BROWSING_DB_LOCAL)
612 TEST_F(ChromePasswordManagerClientTest, 612 TEST_F(ChromePasswordManagerClientTest,
613 VerifyMaybeStartLowReputationRequestCalled) { 613 VerifyMaybeStartPasswordFieldOnFocusRequestCalled) {
614 std::unique_ptr<WebContents> test_web_contents( 614 std::unique_ptr<WebContents> test_web_contents(
615 content::WebContentsTester::CreateTestWebContents( 615 content::WebContentsTester::CreateTestWebContents(
616 web_contents()->GetBrowserContext(), nullptr)); 616 web_contents()->GetBrowserContext(), nullptr));
617 std::unique_ptr<MockChromePasswordManagerClient> client( 617 std::unique_ptr<MockChromePasswordManagerClient> client(
618 new MockChromePasswordManagerClient(test_web_contents.get())); 618 new MockChromePasswordManagerClient(test_web_contents.get()));
619 EXPECT_CALL(*client->password_protection_service(), 619 EXPECT_CALL(*client->password_protection_service(),
620 MaybeStartLowReputationRequest(_, _, _)) 620 MaybeStartPasswordFieldOnFocusRequest(_, _, _))
621 .Times(1); 621 .Times(1);
622 client->CheckSafeBrowsingReputation(GURL("http://foo.com/submit"), 622 client->CheckSafeBrowsingReputation(GURL("http://foo.com/submit"),
623 GURL("http://foo.com/iframe.html")); 623 GURL("http://foo.com/iframe.html"));
624 } 624 }
625 #endif 625 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698