Changed default image in NetworkIconImpl to null image.

Changed default image in NetworkIconImpl to null image.

The default image should remain null until it is updated based on the
network state. Otherwise, the DCHECK in GetBasicImage may fail for VPNs.

BUG=719208
Review-Url: https://codereview.chromium.org/2869243002
Cr-Commit-Position: refs/heads/master@{#470744}
Committed: https://chromium.googlesource.com/chromium/src/+/c44606774b0f1ac7cd2c071cbf6a076506c7cb06

[lesliewatkins, 2017-05-10 00:06:14]

lesliewatkins@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-05-10 17:02:57]

lgtm if/when tested with all technology types + VPN.

https://codereview.chromium.org/2869243002/diff/1/ash/system/network/network_...
File ash/system/network/network_icon.cc (right):

https://codereview.chromium.org/2869243002/diff/1/ash/system/network/network_...
ash/system/network/network_icon.cc:619: // Default image is null.
This is probably fine. Make sure to test both the status area (bottom-right
corner) and the network and VPN lists with active Ethernet, WiFi, VPN, Cellular,
and WiMax connections. You should be able to test most of that except Cellular
on a device, and you can test Cellular on a Linux build by passing in the
following command line argument:

--shill-stub=interactive=1,ethernet=0,wifi=0,cellular=LTE

(Test WiMax with wimax=1 instead of cellular=LTE. It's also a good idea to test
cellular=GSM to test the 3g badge as well).

[lesliewatkins, 2017-05-10 22:25:05]

The CQ bit was checked by lesliewatkins@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:26:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:28:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494455105406980, "parent_rev":
"6280cc1d5a1dccfbe23ca438eed862e245f18614", "commit_rev":
"c44606774b0f1ac7cd2c071cbf6a076506c7cb06"}

[commit-bot: I haz the power, 2017-05-10 23:28:50]

Description was changed from

==========
Changed default image in NetworkIconImpl to null image.

The default image should remain null until it is updated based on the
network state. Otherwise, the DCHECK in GetBasicImage may fail for VPNs.

BUG=719208
==========

to

==========
Changed default image in NetworkIconImpl to null image.

The default image should remain null until it is updated based on the
network state. Otherwise, the DCHECK in GetBasicImage may fail for VPNs.

BUG=719208

Review-Url: https://codereview.chromium.org/2869243002
Cr-Commit-Position: refs/heads/master@{#470744}
Committed:
https://chromium.googlesource.com/chromium/src/+/c44606774b0f1ac7cd2c071cbf6a...
==========

[commit-bot: I haz the power, 2017-05-10 23:28:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c44606774b0f1ac7cd2c071cbf6a...