Move ExpandToParagraphBoundary to VisibleUnits

Move ExpandToParagraphBoundary to VisibleUnits

This patch moves a local function ExpandToParagraphBoundary() in
TextCheckingParagraph.cpp to VisibleUnits, so that it can be shared
by idle time spell checker.

This is a preparation for adding paragraph-level heuristics in idle
time spell checker: crrev.com/2867393003

BUG=517298
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2869213002
Cr-Commit-Position: refs/heads/master@{#470879}
Committed: https://chromium.googlesource.com/chromium/src/+/8084274ab34f75cf3565c6d640c6dce35e707b68

[Xiaocheng, 2017-05-09 22:17:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 22:19:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-09 22:20:46]

Description was changed from

==========
Move ExpandToParagraphBoundary to VisibleUnits

BUG=
==========

to

==========
Move ExpandToParagraphBoundary to VisibleUnits

This patch moves a local function ExpandToParagraphBoundary() in
TextCheckingParagraph.cpp to VisibleUnits, so that it can be shared
by idle time spell checker.

This is a preparation for adding paragraph-level heuristics in idle
time spell checker: crrev.com/2867393003

BUG=517298
TEST=n/a; no behavioral changes
==========

[commit-bot: I haz the power, 2017-05-10 00:22:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:22:09]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Xiaocheng, 2017-05-10 00:27:42]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:29:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-10 00:45:55]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-10 00:45:55]

PTAL.

[yosin_UTC9, 2017-05-10 01:00:38]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-10 01:00:41]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-10 01:00:42]

lgtm

[commit-bot: I haz the power, 2017-05-10 01:01:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:06:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Xiaocheng, 2017-05-10 05:31:40]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 05:33:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 08:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:09:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-10 09:04:20]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:04:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 10:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:21:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-10 17:06:25]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:07:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:20:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-11 06:55:26]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2017-05-11 06:56:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 08:47:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494485726954540, "parent_rev":
"a4759f595e22ff1f32fe998a5f40ef96bfea0acd", "commit_rev":
"8084274ab34f75cf3565c6d640c6dce35e707b68"}

[commit-bot: I haz the power, 2017-05-11 08:47:26]

Description was changed from

==========
Move ExpandToParagraphBoundary to VisibleUnits

This patch moves a local function ExpandToParagraphBoundary() in
TextCheckingParagraph.cpp to VisibleUnits, so that it can be shared
by idle time spell checker.

This is a preparation for adding paragraph-level heuristics in idle
time spell checker: crrev.com/2867393003

BUG=517298
TEST=n/a; no behavioral changes
==========

to

==========
Move ExpandToParagraphBoundary to VisibleUnits

This patch moves a local function ExpandToParagraphBoundary() in
TextCheckingParagraph.cpp to VisibleUnits, so that it can be shared
by idle time spell checker.

This is a preparation for adding paragraph-level heuristics in idle
time spell checker: crrev.com/2867393003

BUG=517298
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2869213002
Cr-Commit-Position: refs/heads/master@{#470879}
Committed:
https://chromium.googlesource.com/chromium/src/+/8084274ab34f75cf3565c6d640c6...
==========

[commit-bot: I haz the power, 2017-05-11 08:47:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8084274ab34f75cf3565c6d640c6...