Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/arc/arc_session.cc

Issue 2869163002: Refactor dbus SessionManagerInterface.StartArcInterface (Closed)
Patch Set: update names Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/arc_session.cc
diff --git a/components/arc/arc_session.cc b/components/arc/arc_session.cc
index 666300576c4e1c0277fc9661111a461d441ec5c4..7ba8ce41386c2c25b5eb37b931a97e2cb8241e57 100644
--- a/components/arc/arc_session.cc
+++ b/components/arc/arc_session.cc
@@ -363,18 +363,17 @@ void ArcSessionImpl::OnSocketCreated(
const cryptohome::Identification cryptohome_id(
user_manager->GetPrimaryUser()->GetAccountId());
- bool disable_boot_completed_broadcast =
+ bool skip_boot_completed_broadcast =
Yusuke Sato 2017/05/11 01:17:24 nit: can you add const?
xc 2017/05/15 18:01:06 Done.
!base::FeatureList::IsEnabled(arc::kBootCompletedBroadcastFeature);
// We only enable /vendor/priv-app when voice interaction is enabled because
// voice interaction service apk would be bundled in this location.
- bool enable_vendor_privileged =
- chromeos::switches::IsVoiceInteractionEnabled();
+ bool scan_vendor_priv_app = chromeos::switches::IsVoiceInteractionEnabled();
Yusuke Sato 2017/05/11 01:17:24 same
xc 2017/05/15 18:01:06 Done.
chromeos::SessionManagerClient* session_manager_client =
chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
session_manager_client->StartArcInstance(
- cryptohome_id, disable_boot_completed_broadcast, enable_vendor_privileged,
+ cryptohome_id, skip_boot_completed_broadcast, scan_vendor_priv_app,
base::Bind(&ArcSessionImpl::OnInstanceStarted, weak_factory_.GetWeakPtr(),
base::Passed(&socket_fd)));
}
« no previous file with comments | « components/arc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698