Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2869053003: [android] Remove newly vestigial uses of override_{compile,isolate}_target{,s} (Closed)

Created:
3 years, 7 months ago by jbudorick
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, ynovikov
CC:
chromium-reviews, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Remove newly vestigial uses of override_{compile,isolate}_target{,s} unnecessary after https://chromium-review.googlesource.com/c/497271/ BUG=716117 Review-Url: https://codereview.chromium.org/2869053003 Cr-Commit-Position: refs/heads/master@{#471171} Committed: https://chromium.googlesource.com/chromium/src/+/59da93bfe66eddf5da25f6cae760fb2813e4ae8d

Patch Set 1 #

Patch Set 2 : rebase on webview rename and boringssl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -680 lines) Patch
M testing/buildbot/chromium.android.json View 1 120 chunks +0 lines, -197 lines 0 comments Download
M testing/buildbot/chromium.android.fyi.json View 1 154 chunks +0 lines, -228 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 56 chunks +0 lines, -90 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 26 chunks +0 lines, -26 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 79 chunks +0 lines, -113 lines 0 comments Download
M testing/buildbot/chromium.swarm.json View 1 14 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
jbudorick
3 years, 7 months ago (2017-05-09 18:31:10 UTC) #5
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-09 19:51:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869053003/20001
3 years, 7 months ago (2017-05-11 23:36:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/59da93bfe66eddf5da25f6cae760fb2813e4ae8d
3 years, 7 months ago (2017-05-12 01:48:58 UTC) #14
ynovikov
testing/buildbot/chromium.gpu.fyi.json is auto-generated, as the comment on top of it indicates. Please change content/test/gpu/generate_buildbot_json.py in ...
3 years, 7 months ago (2017-05-16 22:53:43 UTC) #16
jbudorick
3 years, 7 months ago (2017-05-16 22:58:08 UTC) #17
Message was sent while issue was closed.
On 2017/05/16 22:53:43, ynovikov wrote:
> testing/buildbot/chromium.gpu.fyi.json is auto-generated, as the comment on
top
> of it indicates.
> Please change content/test/gpu/generate_buildbot_json.py in the future.
> I'll take care of it this time.

oops, sorry about that. Thanks for taking care of it here.

Powered by Google App Engine
This is Rietveld 408576698