third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp - Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle (Closed)

Patch Set: BorderColorVisuallyEquals calls BorderColorEquals Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

index b8c5b92157a3238e3777371fc5eb110e224fe7d3..fa7d7eece20025fcab387da35ab4199baaf35d50 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

@@ -18,6 +18,7 @@ void LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(

if (!table.ShouldCollapseBorders())

return;

if (old_style.Border() != table_part.StyleRef().Border() ||

+ !old_style.BorderColorEquals(table_part.StyleRef()) ||

!old_style.RadiiEqual(table_part.StyleRef()) ||

!old_style.BorderSizeEquals(table_part.StyleRef()) ||

(diff.TextDecorationOrColorChanged() &&