third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp - Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2869043002: Store border-*-color on SurroundData in ComputedStyle not BorderColorAndStyle (Closed)

Patch Set: BorderColorVisuallyEquals calls BorderColorEquals Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

index 64a30c8ce86d6615fe4203866266608be207bc10..329a5db96f9d4a8d6cf215ffb3ec8416d44c3109 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

@@ -1957,6 +1957,7 @@ bool StyleResolver::HasAuthorBorder(const StyleResolverState& state) {

const CachedUAStyle* cached_ua_style = state.GetCachedUAStyle();

return cached_ua_style &&

(cached_ua_style->border != state.Style()->Border() ||

+ !cached_ua_style->BorderColorEquals(*state.Style()) ||

(cached_ua_style->border_left_width !=

state.Style()->BorderLeftWidth() ||

cached_ua_style->border_right_width !=