Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2868983004: Fixed PageStateTest.testScrollPositionRestoring flake. (Closed)

Created:
3 years, 7 months ago by kkhorimoto
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fixed PageStateTest.testScrollPositionRestoring flake. This CL adds a step where we scoll to the top whenever a page is loaded, ensuring that the scroll actions end at the expected offset. BUG=702410 Review-Url: https://codereview.chromium.org/2805573002 Cr-Commit-Position: refs/heads/master@{#465815} (cherry picked from commit a6618dc84a89e04cad9c0badf3097b8af91c7795) Review-Url: https://codereview.chromium.org/2868983004 . Cr-Commit-Position: refs/branch-heads/3071@{#471} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/9e512ff4dd1839c9d66904d052d5f030e12e953f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M ios/web/shell/test/page_state_egtest.mm View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kkhorimoto
3 years, 7 months ago (2017-05-08 22:07:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e512ff4dd1839c9d66904d052d5f030e12e953f.

Powered by Google App Engine
This is Rietveld 408576698