Validate input from devtools channel to ensure that position is valid.

Validate input from devtools channel to ensure that position is valid.

A check exists lower in the stack to assert that the position injected
is valid. This check causes the browser to crash. Instead place a similar
check to validate the input and return a verbose error in such situations.

BUG=687457
Review-Url: https://codereview.chromium.org/2868943004
Cr-Commit-Position: refs/heads/master@{#470625}
Committed: https://chromium.googlesource.com/chromium/src/+/694e49d71adce6c37b63d8c8efb708f1b6114e05

[dtapuska, 2017-05-09 19:29:53]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-05-09 19:30:16]

dtapuska@chromium.org changed reviewers:
+ dgozman@chromium.org

[dtapuska, 2017-05-09 19:30:55]

On 2017/05/09 19:30:17, dtapuska wrote:

I attempted to add tests in devtools_protocol_browsertest.cc but it appears that
test harness doesn't deal well with errors returned from SendCommands...

[commit-bot: I haz the power, 2017-05-09 19:31:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 20:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:18:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2017-05-09 21:38:56]

lgtm

https://codereview.chromium.org/2868943004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/input_handler.h (right):

https://codereview.chromium.org/2868943004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.h:132: bool
PointIsWithinContents(gfx::PointF) const;
IIRC, chromium mandates parameter names.

[dtapuska, 2017-05-10 14:04:58]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[dtapuska, 2017-05-10 14:05:04]

https://codereview.chromium.org/2868943004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/input_handler.h (right):

https://codereview.chromium.org/2868943004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/input_handler.h:132: bool
PointIsWithinContents(gfx::PointF) const;
On 2017/05/09 21:38:55, dgozman wrote:
> IIRC, chromium mandates parameter names.

Done.

[commit-bot: I haz the power, 2017-05-10 14:05:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2017-05-10 15:26:20]

The CQ bit was unchecked by dtapuska@chromium.org

[dtapuska, 2017-05-10 15:26:21]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-05-10 15:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2868943004/#ps20001
(title: "Add param name")

[commit-bot: I haz the power, 2017-05-10 15:27:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:15:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494429981820070,
"parent_rev": "c12dbdc00cf31c15ab5ac591c419aa27ad7b9033", "commit_rev":
"694e49d71adce6c37b63d8c8efb708f1b6114e05"}

[commit-bot: I haz the power, 2017-05-10 17:15:25]

Description was changed from

==========
Validate input from devtools channel to ensure that position is valid.

A check exists lower in the stack to assert that the position injected
is valid. This check causes the browser to crash. Instead place a similar
check to validate the input and return a verbose error in such situations.

BUG=687457
==========

to

==========
Validate input from devtools channel to ensure that position is valid.

A check exists lower in the stack to assert that the position injected
is valid. This check causes the browser to crash. Instead place a similar
check to validate the input and return a verbose error in such situations.

BUG=687457

Review-Url: https://codereview.chromium.org/2868943004
Cr-Commit-Position: refs/heads/master@{#470625}
Committed:
https://chromium.googlesource.com/chromium/src/+/694e49d71adce6c37b63d8c8efb7...
==========

[commit-bot: I haz the power, 2017-05-10 17:15:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/694e49d71adce6c37b63d8c8efb7...