Specify --gs-results-bucket arg for chromium.android bots.

Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.

Review-Url: https://codereview.chromium.org/2868943002
Cr-Commit-Position: refs/heads/master@{#471565}
Committed: https://chromium.googlesource.com/chromium/src/+/9116a0309166e8868dddc39014d2eb51951305cb

[mikecase (-- gone --), 2017-05-08 22:54:22]

mikecase@chromium.org changed reviewers:
+ hzl@chromium.org, jbudorick@chromium.org

[mikecase (-- gone --), 2017-05-08 22:54:23]

This should enable screenshot-failure capturing on the bots on chromium.android.
I havent done much with these configs, but I think this is right.

[jbudorick, 2017-05-08 23:04:41]

https://codereview.chromium.org/2868943002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2868943002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:3361:
"--gs-results-bucket=chromium-result-details"
This is the only gtest suite to which you're adding this argument. Why? I'd
leave it to just instrumentation tests.

[mikecase (-- gone --), 2017-05-10 01:13:57]

Fixed.

https://codereview.chromium.org/2868943002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2868943002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:3361:
"--gs-results-bucket=chromium-result-details"
On 2017/05/08 at 23:04:41, jbudorick wrote:
> This is the only gtest suite to which you're adding this argument. Why? I'd
leave it to just instrumentation tests.

Definitely a mistake. Fixed

[wrong jbudorick, 2017-05-10 20:34:44]

jbudorick@google.com changed reviewers:
+ jbudorick@google.com

[wrong jbudorick, 2017-05-10 20:34:45]

lgtm

[jbudorick, 2017-05-10 20:35:18]

On 2017/05/10 20:34:45, wrong jbudorick wrote:
> lgtm

also lgtm

[mikecase (-- gone --), 2017-05-12 23:36:19]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2017-05-12 23:36:20]

Hoping this works!

[commit-bot: I haz the power, 2017-05-12 23:36:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:41:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mikecase (-- gone --), 2017-05-12 23:45:49]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2017-05-12 23:45:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, jbudorick@google.com
Link to the patchset: https://codereview.chromium.org/2868943002/#ps60001
(title: "REBASE")

[commit-bot: I haz the power, 2017-05-12 23:46:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 01:12:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 01:12:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mikecase (-- gone --), 2017-05-13 01:29:12]

waaaah, why won't anything get thru the CQ

[mikecase (-- gone --), 2017-05-13 01:29:15]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-13 01:29:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 03:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 03:54:22]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mikecase (-- gone --), 2017-05-13 04:18:52]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-13 04:19:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mikecase (-- gone --), 2017-05-13 05:11:54]

Might have to commit this with NOTRY=true, the linux_chromium_asan_rel_ng bot is
broken.

[commit-bot: I haz the power, 2017-05-13 05:35:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494649132720500,
"parent_rev": "f556cef44f474c02e486e7c3e4eec685dc50794c", "commit_rev":
"9116a0309166e8868dddc39014d2eb51951305cb"}

[commit-bot: I haz the power, 2017-05-13 05:35:46]

Description was changed from

==========
Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.
==========

to

==========
Specify --gs-results-bucket arg for chromium.android bots.

This should trigger these bots to start uploading screenshots
of test failures as well as uploading render test results in the
future.

Review-Url: https://codereview.chromium.org/2868943002
Cr-Commit-Position: refs/heads/master@{#471565}
Committed:
https://chromium.googlesource.com/chromium/src/+/9116a0309166e8868dddc39014d2...
==========

[commit-bot: I haz the power, 2017-05-13 05:35:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9116a0309166e8868dddc39014d2...

[mikecase (-- gone --), 2017-05-13 14:41:33]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2878033003/ by mikecase@chromium.org.

The reason for reverting is: Need to list jinja template as data dep for python
script. Swaaaarrrrmmmiiinngg!.