Don't pass subpixel offsets through non-translation transforms (composited case)

Don't pass subpixel offsets through non-translation transforms (composited case)

For non-translation transforms, discard subpixel accumulation.

BUG=717882
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[Xianzhu, 2017-05-08 17:53:35]

Description was changed from

==========
Don't pass subpixel offsets through non-translation transforms (composited case)

For non-translation transforms, discard subpixel accumulation.

BUG=717882
==========

to

==========
Don't pass subpixel offsets through non-translation transforms (composited case)

For non-translation transforms, discard subpixel accumulation.

BUG=717882
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-08 17:53:41]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-05-08 17:54:20]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2017-05-08 17:54:20]

Does the issue also apply to squashed layers? If yes, can you help me with a
test case? Thanks.

[commit-bot: I haz the power, 2017-05-08 17:54:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:25:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-05-09 01:12:03]

Squashed layers go through the software painting path, so I think that is
already
covered.

https://codereview.chromium.org/2868933002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.html
(right):

https://codereview.chromium.org/2868933002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.html:3:
div { height: 50px }
How about making the -expected.html file have the exact same transform
but without will-change: transform?

[Xianzhu, 2017-05-09 04:54:23]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 04:54:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 06:03:18]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2017-05-09 15:58:38]

On 2017/05/09 01:12:03, chrishtr wrote:
> Squashed layers go through the software painting path, so I think that is
> already
> covered.

I asked because I saw another PaintLayer::SetSubpixelAccumulation() call from
CompositedLayerMapping::UpdateSquashingLayerGeometry(). However, I noticed that
a layer with a non-translation transform won't be squashed.

https://codereview.chromium.org/2868933002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.html
(right):

https://codereview.chromium.org/2868933002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/compositing/subpixel-offset-scaled-transform-composited-expected.html:3:
div { height: 50px }
On 2017/05/09 01:12:02, chrishtr wrote:
> How about making the -expected.html file have the exact same transform
> but without will-change: transform?

Done.

[chrishtr, 2017-05-09 16:50:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-05-09 16:50:18]

lgtm

[commit-bot: I haz the power, 2017-05-09 16:51:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-09 17:30:43]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-09 17:30:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2868933002/#ps40001
(title: "Rebaseline fast/sub-pixel/transformed-iframe-copy-on-scroll.html")

[commit-bot: I haz the power, 2017-05-09 17:30:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:36:57]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Xianzhu, 2017-05-09 19:22:10]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-09 19:23:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 20:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:26:29]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Xianzhu, 2017-05-09 20:40:35]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:41:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:47:30]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[Xianzhu, 2017-05-09 23:53:26]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:54:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:56:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Xianzhu, 2017-05-10 02:30:33]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:33:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-10 03:47:56]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-10 03:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2868933002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-05-10 03:49:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 06:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 06:48:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-10 15:49:29]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:50:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:56:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-10 18:07:26]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:08:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:35:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-10 22:38:45]

Landed manually. The script failed so no auto emails sent, but the commit has
been landed:

commit d9e07a4e55c864a16fc67366c2a29efd037c5c3c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date:   Wed May 10 15:30:27 2017 -0700

    Don't pass subpixel offsets through non-translation transforms (composited
case)
    
    For non-translation transforms, discard subpixel accumulation.
    
    BUG=717882
   
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    R=chrishtr@chromium.org
    
    Review-Url: https://codereview.chromium.org/2868933002 .
    Cr-Commit-Position: refs/heads/master@{#470733}