Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Clang-based renaming tool only processed idenfitiers within blink and
WTF namespaces and so it has skipped top-level network_instrumentation
namespace in platform/network/NetworkInstrumentation.h

This CL applies Chromium style to the network_instrumentation namespace
and nests this namespace into the blink namespace.

This CL was partially generated using the clang-based renaming tool.

No intended behavior change.

BUG=675877
Review-Url: https://codereview.chromium.org/2868923002
Cr-Commit-Position: refs/heads/master@{#470316}
Committed: https://chromium.googlesource.com/chromium/src/+/9f33458f42d4dc333d684b1c7ac62ded430f1532

[Łukasz Anforowicz, 2017-05-08 17:09:44]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-05-08 17:09:45]

dcheng@, could you PTAL?

This CL fixes one of the left-over m_... occurrences tracked by
https://docs.google.com/spreadsheets/d/1px9A3CxS-Y2r51wsD7_yhqnH_YJTnwb5AQAkR...

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/NetworkInstrumentation.h (left):

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/NetworkInstrumentation.h:15:
namespace network_instrumentation {
Maybe this shouldn't be a top-level namespace, but should be moved into blink
namespace?

https://codereview.chromium.org/2868923002/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2868923002/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:434: "erase",
"find", "front", "insert", "length", "size", "swap",
Above formatting was produced by clang-format.  I've opened
https://bugs.llvm.org//show_bug.cgi?id=32969.

[dcheng, 2017-05-08 18:23:45]

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/NetworkInstrumentation.h (left):

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/NetworkInstrumentation.h:15:
namespace network_instrumentation {
On 2017/05/08 17:09:45, Łukasz A. wrote:
> Maybe this shouldn't be a top-level namespace, but should be moved into blink
> namespace?

Agreed. Is nesting it in blink non-trivial to do in this CL? I would expect most
things to just work, unless we're using it from non-Blink code as well?

[Łukasz Anforowicz, 2017-05-08 18:47:57]

Description was changed from

==========
Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Clang-based renaming tool only processed idenfitiers within blink and
WTF namespaces and so it has skipped network_instrumentation namespace
in third_party/WebKit/Source/platform/network/NetworkInstrumentation.h

This CL applies Chromium style to the network_instrumentation namespace.
This CL was generated using a tweaked clang-based renaming tool.
No intended behavior change.

BUG=675877
==========

to

==========
Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Clang-based renaming tool only processed idenfitiers within blink and
WTF namespaces and so it has skipped top-level network_instrumentation
namespace in platform/network/NetworkInstrumentation.h

This CL applies Chromium style to the network_instrumentation namespace
and nests this namespace into the blink namespace.

This CL was partially generated using the clang-based renaming tool.

No intended behavior change.

BUG=675877
==========

[Łukasz Anforowicz, 2017-05-08 18:48:35]

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/NetworkInstrumentation.h (left):

https://codereview.chromium.org/2868923002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/NetworkInstrumentation.h:15:
namespace network_instrumentation {
On 2017/05/08 18:23:44, dcheng wrote:
> On 2017/05/08 17:09:45, Łukasz A. wrote:
> > Maybe this shouldn't be a top-level namespace, but should be moved into
blink
> > namespace?
> 
> Agreed. Is nesting it in blink non-trivial to do in this CL? I would expect
most
> things to just work, unless we're using it from non-Blink code as well?

Done.

[dcheng, 2017-05-08 18:56:13]

LGTM with comment addressed

https://codereview.chromium.org/2868923002/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2868923002/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:434: "erase",
"find", "front", "insert", "length", "size", "swap",
We can revert this file altogether for now as well, right?

[Łukasz Anforowicz, 2017-05-08 19:06:03]

Thanks.

https://codereview.chromium.org/2868923002/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2868923002/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:434: "erase",
"find", "front", "insert", "length", "size", "swap",
On 2017/05/08 18:56:12, dcheng wrote:
> We can revert this file altogether for now as well, right?

Done.  In theory we could have kept addition of "clear", "find", "swap" above,
but 1) this is not necessary, 2) probably belongs in another CL and 3) is tricky
(blanket blacklisting is not quite right - e.g. probably okay for
Member<T>::Clear to be uppercased).

[Łukasz Anforowicz, 2017-05-08 19:06:08]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-05-08 19:06:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2868923002/#ps40001
(title: "Revert changes to
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp")

[commit-bot: I haz the power, 2017-05-08 19:07:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:23:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2017-05-08 19:30:24]

lukasza@chromium.org changed reviewers:
+ mkwst@chromium.org

[Łukasz Anforowicz, 2017-05-08 19:30:24]

mkwst@, could you PTAL?  (as an owner of third_party/WebKit/Source/platform and
third_party/WebKit/Source/platform/loader)

[Mike West, 2017-05-09 09:27:45]

LGTM

[Łukasz Anforowicz, 2017-05-09 13:31:29]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-05-09 13:32:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 14:05:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494336689302230,
"parent_rev": "b0ec883fdeea4c3b2b13900650c744d22e0b0f22", "commit_rev":
"9f33458f42d4dc333d684b1c7ac62ded430f1532"}

[commit-bot: I haz the power, 2017-05-09 14:05:53]

Description was changed from

==========
Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Clang-based renaming tool only processed idenfitiers within blink and
WTF namespaces and so it has skipped top-level network_instrumentation
namespace in platform/network/NetworkInstrumentation.h

This CL applies Chromium style to the network_instrumentation namespace
and nests this namespace into the blink namespace.

This CL was partially generated using the clang-based renaming tool.

No intended behavior change.

BUG=675877
==========

to

==========
Blink rename follow-up: Use Chromium style in network_instrumentation namespace.

Clang-based renaming tool only processed idenfitiers within blink and
WTF namespaces and so it has skipped top-level network_instrumentation
namespace in platform/network/NetworkInstrumentation.h

This CL applies Chromium style to the network_instrumentation namespace
and nests this namespace into the blink namespace.

This CL was partially generated using the clang-based renaming tool.

No intended behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2868923002
Cr-Commit-Position: refs/heads/master@{#470316}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f33458f42d4dc333d684b1c7ac6...
==========

[commit-bot: I haz the power, 2017-05-09 14:05:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f33458f42d4dc333d684b1c7ac6...