Shape Detection: use Google Play services Face detection where available

Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693, 720019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2868883003
Cr-Commit-Position: refs/heads/master@{#470585}
Committed: https://chromium.googlesource.com/chromium/src/+/7f4fc07c75a0a3908059deb0dae280eafa0bb1da

[mcasas, 2017-05-08 18:59:38]

Description was changed from

==========
Shape Detection: use Google Play services Face detection where available

wip

BUG=718693
==========

to

==========
Shape Detection: use Google Play services Face detection where available

wip

BUG=718693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-05-09 04:13:41]

Description was changed from

==========
Shape Detection: use Google Play services Face detection where available

wip

BUG=718693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-05-09 04:19:09]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-05-09 04:19:09]

reillyg@ PTAL

[Reilly Grant (use Gerrit), 2017-05-09 16:10:08]

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
(right):

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java:62:
if (!mFaceDetector.isOperational()) {
Is the download triggered by the builder.build() call above? Can we fall back to
the built-in face detector while we wait for this one to initialize?

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java:91:
new ArrayList<org.chromium.shape_detection.mojom.Landmark>();
Pass landmarks.size() to provide a hint about the initial capacity.

[mcasas, 2017-05-09 18:22:36]

ptal

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
(right):

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java:62:
if (!mFaceDetector.isOperational()) {
On 2017/05/09 16:10:07, Reilly Grant wrote:
> Is the download triggered by the builder.build() call above? Can we fall back
to
> the built-in face detector while we wait for this one to initialize?

Done.

https://codereview.chromium.org/2868883003/diff/40001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java:91:
new ArrayList<org.chromium.shape_detection.mojom.Landmark>();
On 2017/05/09 16:10:08, Reilly Grant wrote:
> Pass landmarks.size() to provide a hint about the initial capacity.

Done.

[Reilly Grant (use Gerrit), 2017-05-09 18:43:13]

lgtm with a nit

https://codereview.chromium.org/2868883003/diff/60001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java
(right):

https://codereview.chromium.org/2868883003/diff/60001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java:42:
frame = new Frame.Builder().setBitmap(bitmap).build();
return new Frame...

[mcasas, 2017-05-09 19:08:14]

https://codereview.chromium.org/2868883003/diff/60001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java
(right):

https://codereview.chromium.org/2868883003/diff/60001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java:42:
frame = new Frame.Builder().setBitmap(bitmap).build();
On 2017/05/09 18:43:13, Reilly Grant wrote:
> return new Frame...

Done.

[mcasas, 2017-05-09 19:08:34]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 19:09:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 19:37:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[mcasas, 2017-05-09 20:58:38]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-05-09 20:58:39]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2868883003/#ps80001
(title: "reillyg@ nit and filling faceArray[i].landmarks in
FaceDetectionImpl.java")

[commit-bot: I haz the power, 2017-05-09 20:59:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-05-09 21:13:15]

Description was changed from

==========
Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693, 720019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-05-09 21:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 21:23:39]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[mcasas, 2017-05-09 22:48:53]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-09 22:50:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:53:09]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[mcasas, 2017-05-10 00:58:37]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:59:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:04:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[mcasas, 2017-05-10 03:31:46]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:33:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 07:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:27:00]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2017-05-10 14:51:19]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:52:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:49:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494427879853610,
"parent_rev": "3ea544d4e19eff2b81e4a0f9d434a597203e2089", "commit_rev":
"7f4fc07c75a0a3908059deb0dae280eafa0bb1da"}

[commit-bot: I haz the power, 2017-05-10 15:49:20]

Description was changed from

==========
Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693, 720019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: use Google Play services Face detection where available

This CL adds support for Face Detection using Google Play Services
in FaceDetectionImplGmsCore. 

FaceDetectionProviderImpl will create a GMSCore detector if and 
when GMS Core is available, falling back to android.media.FaceDetector
otherwise.

Also the common code dealing with transforming a SharedBufferHandle
into a Frame is moved to SharedBufferUtils.java, convertToFrame(),
and the calls sites refactored.

BUG=718693, 720019
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2868883003
Cr-Commit-Position: refs/heads/master@{#470585}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f4fc07c75a0a3908059deb0dae2...
==========

[commit-bot: I haz the power, 2017-05-10 15:49:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7f4fc07c75a0a3908059deb0dae2...

[Reilly Grant (use Gerrit), 2017-05-11 18:45:22]

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
(right):

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:109:
faceArray[i].landmarks = new Landmark[0];
Why did this become necessary?

[mcasas, 2017-05-11 18:51:23]

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
(right):

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:109:
faceArray[i].landmarks = new Landmark[0];
On 2017/05/11 18:45:22, Reilly Grant wrote:
> Why did this become necessary?

I believe leaving it empty caused a problem when
deserializing: |landmarks| is an array of mojo Structs.

[mcasas, 2017-05-11 19:00:58]

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
File
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java
(right):

https://codereview.chromium.org/2868883003/diff/80001/services/shape_detectio...
services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java:109:
faceArray[i].landmarks = new Landmark[0];
On 2017/05/11 18:51:22, mcasas wrote:
> On 2017/05/11 18:45:22, Reilly Grant wrote:
> > Why did this become necessary?
> 
> I believe leaving it empty caused a problem when
> deserializing: |landmarks| is an array of mojo Structs.

Correction: it fails in the serialization:
> Magic Signature: [Android Java Exception]
org.chromium.mojo.bindings.SerializationException at
org.chromium.mojo.bindings.Encoder.encodeNullPointer(Encoder.java)