Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868873003:
Add SwiftShader libraries to Linux installer package. (Closed)
DescriptionAdd SwiftShader libraries to Linux installer package.
BUG=719507
Review-Url: https://codereview.chromium.org/2868873003
Cr-Commit-Position: refs/heads/master@{#470221}
Committed: https://chromium.googlesource.com/chromium/src/+/8762c915f746100704a494b9dd09075030e77906
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (8 generated)
capn@chromium.org changed reviewers: + mmoss@chromium.org
PTAL
mmoss@google.com changed reviewers: + mmoss@google.com
lgtm https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... File chrome/installer/linux/common/installer.include (right): https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... chrome/installer/linux/common/installer.include:173: if [ -f "${BUILDDIR}/swiftshader/libEGL.so" ]; then Unlike the ANGLE files above, this applies to all channels? Any idea why ANGLE doesn't apply to stable?
capn@chromium.org changed reviewers: + geofflang@chromium.org
On 2017/05/08 at 22:49:29, mmoss wrote: > lgtm > > https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... > File chrome/installer/linux/common/installer.include (right): > > https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... > chrome/installer/linux/common/installer.include:173: if [ -f "${BUILDDIR}/swiftshader/libEGL.so" ]; then > Unlike the ANGLE files above, this applies to all channels? Any idea why ANGLE doesn't apply to stable? At the moment Chromium still talks directly to OpenGL on Linux, but the work to make it go through ANGLE instead to match Windows and thereby simplify the architecture in underways, and they're monitoring for issues on Beta before releasing to Stable in M60 or M61, if I'm not mistaken. Using SwiftShader as a fallback for when the GPU is blacklisted is independent to this, and is intended to go in M59.
The CQ bit was checked by capn@chromium.org
On 2017/05/08 23:55:40, capn wrote: > On 2017/05/08 at 22:49:29, mmoss wrote: > > lgtm > > > > > https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... > > File chrome/installer/linux/common/installer.include (right): > > > > > https://codereview.chromium.org/2868873003/diff/1/chrome/installer/linux/comm... > > chrome/installer/linux/common/installer.include:173: if [ -f > "${BUILDDIR}/swiftshader/libEGL.so" ]; then > > Unlike the ANGLE files above, this applies to all channels? Any idea why ANGLE > doesn't apply to stable? > > At the moment Chromium still talks directly to OpenGL on Linux, but the work to > make it go through ANGLE instead to match Windows and thereby simplify the > architecture in underways, and they're monitoring for issues on Beta before > releasing to Stable in M60 or M61, if I'm not mistaken. Using SwiftShader as a > fallback for when the GPU is blacklisted is independent to this, and is intended > to go in M59. sg, thanks
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/05/09 00:07:03, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. OMG, I hate you CQ committer checks! Let me re-login with @chromium.
lgtm
The CQ bit was checked by mmoss@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494288796996570, "parent_rev":
"f94b6d7b81f46461c6ef205c06c75b5fa6aca6a8", "commit_rev":
"8762c915f746100704a494b9dd09075030e77906"}
Message was sent while issue was closed.
Description was changed from ========== Add SwiftShader libraries to Linux installer package. BUG=719507 ========== to ========== Add SwiftShader libraries to Linux installer package. BUG=719507 Review-Url: https://codereview.chromium.org/2868873003 Cr-Commit-Position: refs/heads/master@{#470221} Committed: https://chromium.googlesource.com/chromium/src/+/8762c915f746100704a494b9dd09... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8762c915f746100704a494b9dd09... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
