Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2868793004: Revert of Statically link own version of FreeType on Linux (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
CC:
vapier, chromium-reviews, stevenjb
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Statically link own version of FreeType on Linux (patchset #3 id:40001 of https://codereview.chromium.org/2863063003/ ) Reason for revert: Deps change picked up by official builder: https://luci-milo.appspot.com/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/17727 Please remove freetype from these files: chrome/installer/linux/debian/expected_deps_ia32_jessie chrome/installer/linux/debian/expected_deps_x64_jessie chrome/installer/linux/rpm/expected_deps_i386 chrome/installer/linux/rpm/expected_deps_x86_64 Original issue's description: > Statically link own version of FreeType on Linux > > For color font support, CFF and CFF2 rasterization, and OpenType font > variations, latest security fixes, Chrome needs an up-to-date version of > FreeType (more details on the bug). Since distributions are too far > behind in the shipped system FreeType versions, we need to start linking > in our own copy. > > For distributions that build their own Chromium this CL introduces a > switch use_system_freetype which can be used to keep the old linking > configuration at the expense of risking introduction of text rendering > and security regressions if the system FreeType is too old. > > BUG=274030 > > Review-Url: https://codereview.chromium.org/2863063003 > Cr-Commit-Position: refs/heads/master@{#470097} > Committed: https://chromium.googlesource.com/chromium/src/+/c15bda3bf4bbe231186176da9d809fed356f8cbf TBR=vapier@chromium.org,bungeman@chromium.org,dpranke@chromium.org,eae@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=274030 Review-Url: https://codereview.chromium.org/2868793004 Cr-Commit-Position: refs/heads/master@{#470149} Committed: https://chromium.googlesource.com/chromium/src/+/52eb504ead78db774e2e21307e6322c1f7ce867f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M build/config/freetype/BUILD.gn View 1 chunk +1 line, -12 lines 0 comments Download
M build/config/linux/pangocairo/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M build/linux/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/freetype/README.chromium View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tom Anderson
Created Revert of Statically link own version of FreeType on Linux
3 years, 7 months ago (2017-05-08 22:17:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793004/1
3 years, 7 months ago (2017-05-08 22:18:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/52eb504ead78db774e2e21307e6322c1f7ce867f
3 years, 7 months ago (2017-05-08 22:20:08 UTC) #6
eae
The entire point of the change was to include freetype. This *was* intentional, I guess ...
3 years, 7 months ago (2017-05-08 22:22:10 UTC) #7
Tom (Use chromium acct)
3 years, 7 months ago (2017-05-08 22:30:15 UTC) #8
Message was sent while issue was closed.
On 2017/05/08 22:22:10, eae wrote:
> The entire point of the change was to include freetype.
> 

I know, but by bundling freetype, you've removed the dependency on the system
freetype.  It's just a matter of updating the deps files in the reland.

> This *was* intentional, I guess we need to update
> chrome/installer/linux/rpm/expected_deps_i386
> chrome/installer/linux/rpm/expected_deps_x86_64
> 

Don't forget about the debian ones too:
chrome/installer/linux/debian/expected_deps_ia32_jessie
chrome/installer/linux/debian/expected_deps_x64_jessie

> before trying to reland.
> 
> Thanks.

Powered by Google App Engine
This is Rietveld 408576698