Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2868793003: RE-add the ability to delete notification ids unknown by the display service. (Closed)

Created:
3 years, 7 months ago by Miguel Garcia
Modified:
3 years, 7 months ago
Reviewers:
Peter Beverloo, miguelg
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

RE-add the ability to delete notification ids unknown by the display service. This is a manual revert of 865a357dda206267aafd20d23382b452cec8c084 BUG=700343 Review-Url: https://codereview.chromium.org/2868793003 Cr-Commit-Position: refs/heads/master@{#470930} Committed: https://chromium.googlesource.com/chromium/src/+/abc61bbbad13394f8286af84eb49d60d3f4b1882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -259 lines) Patch
M content/browser/notifications/notification_database.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 3 chunks +81 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.h View 2 chunks +3 lines, -79 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 chunk +1 line, -172 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (15 generated)
Miguel Garcia
3 years, 7 months ago (2017-05-08 20:31:05 UTC) #5
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-10 14:01:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793003/1
3 years, 7 months ago (2017-05-10 14:06:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450056)
3 years, 7 months ago (2017-05-10 16:34:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793003/1
3 years, 7 months ago (2017-05-10 16:55:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450438)
3 years, 7 months ago (2017-05-10 19:15:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793003/1
3 years, 7 months ago (2017-05-11 06:30:32 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451501)
3 years, 7 months ago (2017-05-11 07:56:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793003/1
3 years, 7 months ago (2017-05-11 10:58:45 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 12:16:30 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abc61bbbad13394f8286af84eb49...

Powered by Google App Engine
This is Rietveld 408576698