Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 2868783005: Make ETextSecurity an enum class. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
aboxhall, aboxhall+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, haraken, jchaffraix+rendering, je_julie, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ETextSecurity an enum class. This patch makes ETextSecurity an enum class for better type safety. BUG=684966 TBR=aboxhall@chromium.org Review-Url: https://codereview.chromium.org/2868783005 Cr-Commit-Position: refs/heads/master@{#471239} Committed: https://chromium.googlesource.com/chromium/src/+/39f50e39f87993743d1253c33dc5fe67caa5da05

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 18 (13 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-12 00:02:00 UTC) #8
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-12 03:51:26 UTC) #11
shend
Hi Alice, TBRing you as discussed.
3 years, 7 months ago (2017-05-12 06:47:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868783005/20001
3 years, 7 months ago (2017-05-12 06:48:33 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 06:54:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39f50e39f87993743d1253c33dc5...

Powered by Google App Engine
This is Rietveld 408576698