Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)
Patch Set: tweak comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
diff --git a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
index 66a8295c998769e718f1d96e113b64dffc22fc0b..76a0a9b46ce380dd306a1ffc0d56754076ba9e07 100644
--- a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
+++ b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
@@ -21,6 +21,10 @@ class Browser;
class TestPermissionBubbleViewDelegate : public PermissionPrompt::Delegate {
public:
TestPermissionBubbleViewDelegate();
+ ~TestPermissionBubbleViewDelegate() override;
+
+ const std::vector<PermissionRequest*>& Requests() override;
+ const std::vector<bool>& AcceptStates() override;
void ToggleAccept(int, bool) override {}
void TogglePersist(bool) override {}
@@ -28,7 +32,14 @@ class TestPermissionBubbleViewDelegate : public PermissionPrompt::Delegate {
void Deny() override {}
void Closing() override {}
+ void set_requests(std::vector<PermissionRequest*> requests) {
+ requests_ = requests;
+ }
+
private:
+ std::vector<PermissionRequest*> requests_;
+ std::vector<bool> accept_states_;
+
DISALLOW_COPY_AND_ASSIGN(TestPermissionBubbleViewDelegate);
};
@@ -45,8 +56,6 @@ class PermissionBubbleBrowserTest : public ExtensionBrowserTest {
// Opens an app window, and returns the associated browser.
Browser* OpenExtensionAppWindow();
- std::vector<PermissionRequest*> requests();
- std::vector<bool> accept_states() { return accept_states_; }
PermissionPrompt::Delegate* test_delegate() { return &test_delegate_; }
private:

Powered by Google App Engine
This is Rietveld 408576698