Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4204)

Unified Diff: chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)
Patch Set: tweak comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
diff --git a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
index fe6b7a00371f4825f86f121d8c5d28e7cfdfbfa1..19a2548437ed1410b4dfaaa0269ff81afa5714d6 100644
--- a/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
+++ b/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
@@ -22,6 +22,17 @@ TestPermissionBubbleViewDelegate::TestPermissionBubbleViewDelegate()
: PermissionPrompt::Delegate() {
}
+TestPermissionBubbleViewDelegate::~TestPermissionBubbleViewDelegate() {}
+
+const std::vector<PermissionRequest*>&
+TestPermissionBubbleViewDelegate::Requests() {
+ return requests_;
+}
+
+const std::vector<bool>& TestPermissionBubbleViewDelegate::AcceptStates() {
+ return accept_states_;
+}
+
PermissionBubbleBrowserTest::PermissionBubbleBrowserTest() {
}
@@ -35,6 +46,10 @@ void PermissionBubbleBrowserTest::SetUpOnMainThread() {
requests_.push_back(base::MakeUnique<MockPermissionRequest>(
"Request 1", l10n_util::GetStringUTF8(IDS_PERMISSION_ALLOW),
l10n_util::GetStringUTF8(IDS_PERMISSION_DENY)));
+
+ std::vector<PermissionRequest*> raw_requests;
+ raw_requests.push_back(requests_[0].get());
+ test_delegate_.set_requests(raw_requests);
}
Browser* PermissionBubbleBrowserTest::OpenExtensionAppWindow() {
@@ -56,13 +71,6 @@ Browser* PermissionBubbleBrowserTest::OpenExtensionAppWindow() {
return app_browser;
}
-std::vector<PermissionRequest*> PermissionBubbleBrowserTest::requests() {
- std::vector<PermissionRequest*> result;
- for (const auto& request : requests_)
- result.push_back(request.get());
- return result;
-}
-
PermissionBubbleKioskBrowserTest::PermissionBubbleKioskBrowserTest() {
}

Powered by Google App Engine
This is Rietveld 408576698