chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h - Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)

Patch Set: tweak comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm ('k') | chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h

index 18bc0ef4ab165e7c9a27507e1e72033d5bc3db6b..c12423b3b861514e87325deaaff3147ea3dcd012 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h

@@ -16,7 +16,6 @@ class Browser;

class LocationBarDecoration;

@class MenuController;

class PermissionBubbleCocoa;

-class PermissionRequest;

@interface PermissionBubbleController

: BaseBubbleController<NSTextViewDelegate> {

@@ -54,10 +53,8 @@ class PermissionRequest;

+ (bool)hasVisibleLocationBarForBrowser:(Browser*)browser;

// Makes the bubble visible. The bubble will be populated with text retrieved

-// from |requests|. |delegate| will receive callbacks for user actions.

-- (void)showWithDelegate:(PermissionPrompt::Delegate*)delegate

- forRequests:(const std::vector<PermissionRequest*>&)requests

- acceptStates:(const std::vector<bool>&)acceptStates;

+// from |delegate|, which will also receive callbacks for user actions.

+- (void)showWithDelegate:(PermissionPrompt::Delegate*)delegate;

// Will reposition the bubble based in case the anchor or parent should change.

- (void)updateAnchorPosition;