chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm - Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)

Patch Set: tweak comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm

index de7d740092308960efb6bd8b1b3f4681d2b5d20f..a2a7fe5baa6c1c1391e917ca293f81c35e3beb2d 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm

@@ -17,7 +17,7 @@

IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, HasLocationBarByDefault) {

PermissionBubbleCocoa bubble(browser());

bubble.SetDelegate(test_delegate());

- bubble.Show(requests(), accept_states());

+ bubble.Show();

EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);

bubble.Hide();

}

@@ -28,7 +28,7 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,

PermissionBubbleCocoa bubble(browser());

bubble.SetDelegate(test_delegate());

- bubble.Show(requests(), accept_states());

+ bubble.Show();

EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);

FullscreenController* controller =

@@ -61,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,

PermissionBubbleCocoa bubble(browser());

bubble.SetDelegate(test_delegate());

- bubble.Show(requests(), accept_states());

+ bubble.Show();

EXPECT_TRUE([bubble.bubbleController_ hasVisibleLocationBar]);

FullscreenController* controller =

@@ -83,7 +83,7 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, AppHasNoLocationBar) {

Browser* app_browser = OpenExtensionAppWindow();

PermissionBubbleCocoa bubble(app_browser);

bubble.SetDelegate(test_delegate());

- bubble.Show(requests(), accept_states());

+ bubble.Show();

EXPECT_FALSE([bubble.bubbleController_ hasVisibleLocationBar]);

bubble.Hide();

}

@@ -94,7 +94,7 @@ IN_PROC_BROWSER_TEST_F(PermissionBubbleKioskBrowserTest,

DISABLED_KioskHasNoLocationBar) {

PermissionBubbleCocoa bubble(browser());

bubble.SetDelegate(test_delegate());

- bubble.Show(requests(), accept_states());

+ bubble.Show();

EXPECT_FALSE([bubble.bubbleController_ hasVisibleLocationBar]);

bubble.Hide();

}