chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm - Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

Issue 2868783002: Move requests from Show() argument to PermissionPrompt::Delegate (Closed)

Patch Set: tweak comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h ('k') | chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_browser_test.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

index fc032b002e8ce9ae9058bb1f7b7444432e4b06b2..6f644ade432c72a9660d1a356d4eed10cb55c4fa 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm

@@ -17,9 +17,7 @@ PermissionBubbleCocoa::PermissionBubbleCocoa(Browser* browser)

PermissionBubbleCocoa::~PermissionBubbleCocoa() {

}

-void PermissionBubbleCocoa::Show(

- const std::vector<PermissionRequest*>& requests,

- const std::vector<bool>& accept_state) {

+void PermissionBubbleCocoa::Show() {

DCHECK(browser_);

if (!bubbleController_) {

@@ -28,9 +26,7 @@ void PermissionBubbleCocoa::Show(

bridge:this];

}

- [bubbleController_ showWithDelegate:delegate_

- forRequests:requests

- acceptStates:accept_state];

+ [bubbleController_ showWithDelegate:delegate_];

}

void PermissionBubbleCocoa::Hide() {