Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2868743002: Provide a way to obtain WebLocalFrameBase from a LocalFrame. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide a way to obtain WebLocalFrameBase from a LocalFrame. Provide methods that allow callers to obtain an instance of WebLocalFrameBase rather than WebLocalFrameImpl, and use this in WebDocument to remove a dependency on WebLocalFrameImpl. This moves the meat of https://codereview.chromium.org/2863913002 to this CL, as it was too difficult to concicely break the dependencies on other components in web/. I used the existing "GetWebLayerTreeView" method as the basis for calling the new method "GetWebLocalFrameBase". BUG=708879 Review-Url: https://codereview.chromium.org/2868743002 Cr-Commit-Position: refs/heads/master@{#469920} Committed: https://chromium.googlesource.com/chromium/src/+/60a6ebd54a2ab983980775cab24ac9d89cfab27d

Patch Set 1 #

Patch Set 2 : Create WebLocalFrameBase::FromFrame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 2 chunks +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/WebLocalFrameBase.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 3 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
slangley
haraken@ - this is a subset of the previous CL that was discussed (https://codereview.chromium.org/2863913002).
3 years, 7 months ago (2017-05-08 05:35:34 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-05-08 05:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868743002/20001
3 years, 7 months ago (2017-05-08 05:57:56 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 08:10:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60a6ebd54a2ab983980775cab24a...

Powered by Google App Engine
This is Rietveld 408576698