Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.h

Issue 2868733002: Move failed URLRequest checking to OnUrlRequestCompleted (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
index f1e9b7b35dc0f327126059dbe40077bda897f551..666c3f6dadacec6ab7bf4714aef537b5af0155fc 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
@@ -59,6 +59,7 @@ class ChromeDataUseAscriber : public DataUseAscriber {
net::URLRequest* request) override;
ChromeDataUseRecorder* GetDataUseRecorder(
const net::URLRequest& request) override;
+ void OnUrlRequestCompleted(net::URLRequest* request, bool started) override;
tbansal1 2017/05/09 01:14:43 pass const ref instead of raw ptr?
rajendrant 2017/05/11 20:31:39 Done.
void OnUrlRequestDestroyed(net::URLRequest* request) override;
std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier()
const override;

Powered by Google App Engine
This is Rietveld 408576698