Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.h

Issue 2868733002: Move failed URLRequest checking to OnUrlRequestCompleted (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_ 5 #ifndef CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_
6 #define CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_ 6 #define CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 public: 52 public:
53 ChromeDataUseAscriber(); 53 ChromeDataUseAscriber();
54 54
55 ~ChromeDataUseAscriber() override; 55 ~ChromeDataUseAscriber() override;
56 56
57 // DataUseAscriber implementation: 57 // DataUseAscriber implementation:
58 ChromeDataUseRecorder* GetOrCreateDataUseRecorder( 58 ChromeDataUseRecorder* GetOrCreateDataUseRecorder(
59 net::URLRequest* request) override; 59 net::URLRequest* request) override;
60 ChromeDataUseRecorder* GetDataUseRecorder( 60 ChromeDataUseRecorder* GetDataUseRecorder(
61 const net::URLRequest& request) override; 61 const net::URLRequest& request) override;
62 void OnUrlRequestCompleted(net::URLRequest* request, bool started) override;
tbansal1 2017/05/09 01:14:43 pass const ref instead of raw ptr?
rajendrant 2017/05/11 20:31:39 Done.
62 void OnUrlRequestDestroyed(net::URLRequest* request) override; 63 void OnUrlRequestDestroyed(net::URLRequest* request) override;
63 std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier() 64 std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier()
64 const override; 65 const override;
65 66
66 // Called when a render frame host is created. When the render frame is a main 67 // Called when a render frame host is created. When the render frame is a main
67 // frame, |main_render_process_id| and |main_render_frame_id| should be -1. 68 // frame, |main_render_process_id| and |main_render_frame_id| should be -1.
68 void RenderFrameCreated(int render_process_id, 69 void RenderFrameCreated(int render_process_id,
69 int render_frame_id, 70 int render_frame_id,
70 int main_render_process_id, 71 int main_render_process_id,
71 int main_render_frame_id); 72 int main_render_frame_id);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 175
175 // Contains the mainframe IDs that are currently visible. 176 // Contains the mainframe IDs that are currently visible.
176 base::hash_set<RenderFrameHostID> visible_main_render_frames_; 177 base::hash_set<RenderFrameHostID> visible_main_render_frames_;
177 178
178 DISALLOW_COPY_AND_ASSIGN(ChromeDataUseAscriber); 179 DISALLOW_COPY_AND_ASSIGN(ChromeDataUseAscriber);
179 }; 180 };
180 181
181 } // namespace data_use_measurement 182 } // namespace data_use_measurement
182 183
183 #endif // CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_ 184 #endif // CHROME_BROWSER_DATA_USE_MEASUREMENT_CHROME_DATA_USE_ASCRIBER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698