Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868723006:
Changing focus ring color by node. Focus ring can now change color without changing bounds (Closed)
|
Created:
3 years, 7 months ago by elichtenberg Modified:
3 years, 7 months ago CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChanging focus ring color by node. Focus ring can now change color without changing bounds
BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2868723006
Cr-Commit-Position: refs/heads/master@{#470648}
Committed: https://chromium.googlesource.com/chromium/src/+/77346d2ec5bd54cfcb9cdebe97127b725af60db5
Patch Set 1 #
Total comments: 2
Patch Set 2 : Responded to comment #
Messages
Total messages: 26 (14 generated)
Description was changed from ========== Changing focus ring color by node. Focus ring can now change color without changing bounds BUG=593885 ========== to ========== Changing focus ring color by node. Focus ring can now change color without changing bounds BUG=593885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by elichtenberg@google.com to run a CQ dry run
elichtenberg@google.com changed reviewers: + dmazzoni@chromium.org, dtseng@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2868723006/diff/1/chrome/browser/chromeos/ui/... File chrome/browser/chromeos/ui/focus_ring_layer.cc (right): https://codereview.chromium.org/2868723006/diff/1/chrome/browser/chromeos/ui/... chrome/browser/chromeos/ui/focus_ring_layer.cc:81: gfx::Rect* layer_bounds = If you create an object with "new" you also have to delete it. Simpler is to just create it on the stack like this: gfx::Rect layer_bounds(0, 0, bounds.width(), bounds.height()); Then you don't need the * when passing it to SchedulePaint.
https://codereview.chromium.org/2868723006/diff/1/chrome/browser/chromeos/ui/... File chrome/browser/chromeos/ui/focus_ring_layer.cc (right): https://codereview.chromium.org/2868723006/diff/1/chrome/browser/chromeos/ui/... chrome/browser/chromeos/ui/focus_ring_layer.cc:81: gfx::Rect* layer_bounds = On 2017/05/09 17:05:09, dmazzoni wrote: > If you create an object with "new" you also have to delete it. Simpler is to > just create it on the stack like this: > > gfx::Rect layer_bounds(0, 0, bounds.width(), bounds.height()); > > Then you don't need the * when passing it to SchedulePaint. Done.
dmazzoni@chromium.org changed reviewers: + xiyuan@chromium.org
lgtm +xiyuan for owners review
lgtm
The CQ bit was checked by elichtenberg@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by elichtenberg@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by elichtenberg@google.com
The CQ bit was checked by elichtenberg@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by elichtenberg@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494434811103810,
"parent_rev": "0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf", "commit_rev":
"77346d2ec5bd54cfcb9cdebe97127b725af60db5"}
Message was sent while issue was closed.
Description was changed from ========== Changing focus ring color by node. Focus ring can now change color without changing bounds BUG=593885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Changing focus ring color by node. Focus ring can now change color without changing bounds BUG=593885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2868723006 Cr-Commit-Position: refs/heads/master@{#470648} Committed: https://chromium.googlesource.com/chromium/src/+/77346d2ec5bd54cfcb9cdebe9712... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/77346d2ec5bd54cfcb9cdebe9712... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
