Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2868723005: [CUPS] Change manufacturer selection should clear model selection in the dropdown list. (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Change manufacturer selection should clear model selection in the dropdown list. BUG=706950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2868723005 Cr-Commit-Position: refs/heads/master@{#470647} Committed: https://chromium.googlesource.com/chromium/src/+/0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
3 years, 7 months ago (2017-05-09 00:35:18 UTC) #3
michaelpg
lgtm
3 years, 7 months ago (2017-05-09 19:10:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868723005/1
3 years, 7 months ago (2017-05-10 16:52:47 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 18:24:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e64a9ca93f8ec7cb3ef6625903b...

Powered by Google App Engine
This is Rietveld 408576698