Device: enable device_junit_tests in bots

Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2 (see https://crbug.com/719765).

BUG=719121
Review-Url: https://codereview.chromium.org/2868693002
Cr-Commit-Position: refs/heads/master@{#470459}
Committed: https://chromium.googlesource.com/chromium/src/+/eddfbeb9499bc63e771b234f1817b67fe88b10d0

[mcasas, 2017-05-07 04:28:34]

Description was changed from

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".


BUG=719121
==========

to

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled due to 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)

(l.278 after disabling it)

BUG=719121
==========

[mcasas, 2017-05-07 05:03:13]

Description was changed from

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled due to 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)

(l.278 after disabling it)

BUG=719121
==========

to

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled due to 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)

(l.277 after disabling it)

BUG=719121
==========

[mcasas, 2017-05-07 05:33:35]

Patchset #2 (id:20001) has been deleted

[mcasas, 2017-05-07 17:50:17]

Description was changed from

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled due to 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)

(l.277 after disabling it)

BUG=719121
==========

to

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2:
 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)
[...]
(l.277 is the one failing after disabling it)

BUG=719121
==========

[mcasas, 2017-05-07 17:51:55]

mcasas@chromium.org changed reviewers:
+ mattreynolds@chromium.org, reillyg@chromium.org

[mcasas, 2017-05-07 17:51:56]

reillyg@ PTAL
matterynolds@ PTAL

[Reilly Grant (use Gerrit), 2017-05-08 21:29:02]

lgtm with a nit

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
File
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
(right):

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:259:
// @Test
Remove this line.

[mcasas, 2017-05-08 23:36:42]

mcasas@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mcasas, 2017-05-08 23:36:43]

jbudorick@ PTAL

A question: I tried having both statements:

  @Test 
  @DisabledTest

but that did not do the trick: the test ran and kept
failing, was this expected? (This is a Robolectric test)

[jbudorick, 2017-05-08 23:41:44]

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
File
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
(right):

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:260:
@DisabledTest(message = "One mapping fails the index check")
@DisabledTest does nothing in junit/robolectric tests. Use @Ignore instead, e.g.
https://codesearch.chromium.org/chromium/src/content/public/android/junit/src...

[mcasas, 2017-05-08 23:56:52]

ptal

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
File
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
(right):

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:259:
// @Test
On 2017/05/08 21:29:01, Reilly Grant wrote:
> Remove this line.

Reenabled per jbudorick@ solution of using @Ignore

https://codereview.chromium.org/2868693002/diff/40001/device/gamepad/android/...
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:260:
@DisabledTest(message = "One mapping fails the index check")
On 2017/05/08 23:41:43, jbudorick wrote:
> @DisabledTest does nothing in junit/robolectric tests. Use @Ignore instead,
e.g.
>
https://codesearch.chromium.org/chromium/src/content/public/android/junit/src...

Thanks! Done.

[mcasas, 2017-05-09 00:19:09]

Description was changed from

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2:
 
 RUN      ]
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings
java.lang.AssertionError: expected:<101.0> but was:<102.0>
[...]
	at
org.chromium.device.gamepad.GamepadMappingsTest.testPS4GamepadMappings(GamepadMappingsTest.java:276)
[...]
(l.277 is the one failing after disabling it)

BUG=719121
==========

to

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2 (see https://crbug.com/719765).

BUG=719121
==========

[Reilly Grant (use Gerrit), 2017-05-09 00:43:08]

rs lgtm

[mcasas, 2017-05-09 15:57:54]

On 2017/05/09 00:43:08, Reilly Grant wrote:
> rs lgtm

Ping jbudorick@

[jbudorick, 2017-05-09 15:59:29]

On 2017/05/09 15:57:54, mcasas wrote:
> On 2017/05/09 00:43:08, Reilly Grant wrote:
> > rs lgtm
> 
> Ping jbudorick@

oops, didn't realize you were looking for more than an answer to your question
:|

lgtm

[mcasas, 2017-05-09 16:18:43]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 16:19:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattreynolds, 2017-05-09 17:21:57]

lgtm

[mcasas, 2017-05-09 18:30:15]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-05-09 18:30:19]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:30:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-05-10 00:29:31]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-05-10 00:29:49]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:30:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 02:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:37:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[mcasas, 2017-05-10 03:32:07]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:33:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:47:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494387127629070,
"parent_rev": "6b6e6ed31f8ea183957b3a6e9abeb8360e04512c", "commit_rev":
"eddfbeb9499bc63e771b234f1817b67fe88b10d0"}

[commit-bot: I haz the power, 2017-05-10 04:48:14]

Description was changed from

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2 (see https://crbug.com/719765).

BUG=719121
==========

to

==========
Device: enable device_junit_tests in bots

Added device_junit_tests to appropriate locations to have them
in targets "Android Tests" and "Android Tests (dbg)".

One test is disabled in PS2 (see https://crbug.com/719765).

BUG=719121

Review-Url: https://codereview.chromium.org/2868693002
Cr-Commit-Position: refs/heads/master@{#470459}
Committed:
https://chromium.googlesource.com/chromium/src/+/eddfbeb9499bc63e771b234f1817...
==========

[commit-bot: I haz the power, 2017-05-10 04:48:18]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/eddfbeb9499bc63e771b234f1817...