Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2868683002: adds 'mov reg32, fs:[imm]' and 'inc byte ptr [reg32]' to the assembler (Closed)

Created:
3 years, 7 months ago by 0vercl0k
Modified:
3 years, 7 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

adds 'mov reg32, fs:[imm]' and 'inc byte ptr [reg32]' to the assembler This change adds the two new instructions to the assembler: - mov reg32, fs:[imm] - inc byte [reg32] BUG= R=chrisha@chromium.org Review-Url: https://codereview.chromium.org/2868683002 Committed: https://github.com/google/syzygy/commit/a43a90ba2f07fd49b8eb6e45671e8773336e6c42

Patch Set 1 #

Patch Set 2 : fix build break, simplify the encoding and test it with all gprs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M syzygy/assm/assembler_base.h View 2 chunks +3 lines, -0 lines 0 comments Download
M syzygy/assm/assembler_base_impl.h View 1 2 chunks +23 lines, -0 lines 0 comments Download
M syzygy/assm/assembler_unittest.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
chrisha
lgtm Awesome! lgtm
3 years, 7 months ago (2017-05-08 19:51:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868683002/1
3 years, 7 months ago (2017-05-08 19:51:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg_try on master.tryserver.client.syzygy (JOB_FAILED, https://build.chromium.org/p/tryserver.client.syzygy/builders/win_dbg_try/builds/736)
3 years, 7 months ago (2017-05-08 20:04:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868683002/20001
3 years, 7 months ago (2017-05-09 05:58:18 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 05:58:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/a43a90ba2f07fd49b8eb6e45671e8773336e6c42

Powered by Google App Engine
This is Rietveld 408576698