Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2868593002: [Android] Enable multidex for release builds of chrome_public_test_apk. (RELAND) (Closed)

Created:
3 years, 7 months ago by jbudorick
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Android] Enable multidex for release builds of chrome_public_test_apk. (RELAND) cherry pick to M59 BUG=712852 (cherry picked from commit 78730f18fc734d034e44d0dc63091562be82edae) Review-Url: https://codereview.chromium.org/2868593002 . Cr-Commit-Position: refs/branch-heads/3071@{#426} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/654894f8b0de9c8df52f701a95c3c2514b2715c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -13 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 1 chunk +3 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java View 2 chunks +0 lines, -3 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java View 2 chunks +8 lines, -4 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java View 2 chunks +8 lines, -4 lines 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/BaseChromiumRunnerCommon.java View 1 chunk +162 lines, -0 lines 0 comments Download
M build/android/main_dex_classes.flags View 1 chunk +7 lines, -0 lines 0 comments Download
A build/android/multidex.flags View 1 chunk +12 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbudorick
3 years, 7 months ago (2017-05-05 22:40:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
654894f8b0de9c8df52f701a95c3c2514b2715c4.

Powered by Google App Engine
This is Rietveld 408576698