Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2868583002: Cleanup SetViewportLayersFromIds calls in LayerTreeImplTest (Closed)

Created:
3 years, 7 months ago by pdr.
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup SetViewportLayersFromIds calls in LayerTreeImplTest https://crrev.com/76ddc8770c3b80af44f97ddaa32d14098beb0ff8 added a call to SetViewportLayersFromIds with layer ids of 0 instead of INVALID_ID, but these 0 layer ids are not valid layers. This patch switches these 0's to real invalid layer ids. In addition, there is no need to call SetViewportLayersFromIds twice so the two calls have been unified. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2868583002 Cr-Commit-Position: refs/heads/master@{#470578} Committed: https://chromium.googlesource.com/chromium/src/+/a2fe572b1f2bb6e2f9c59227de08a738eed0c00e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
pdr.
Split out of another change for ease of reviewing.
3 years, 7 months ago (2017-05-05 22:17:35 UTC) #3
danakj
LGTM
3 years, 7 months ago (2017-05-10 14:42:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868583002/1
3 years, 7 months ago (2017-05-10 14:43:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:20:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2fe572b1f2bb6e2f9c59227de08...

Powered by Google App Engine
This is Rietveld 408576698