Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2868543002: DevTools: move FileSystemMapping under persistence/ module (Closed)

Created:
3 years, 7 months ago by lushnikov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move FileSystemMapping under persistence/ module This patch: - moves Workspace.FileSystemMapping under persistence/ module - splits out "WorkspaceSettingsTab" from SettingsScreen and moves it under persistence/ module. This is needed since WorkspaceSettingsTab refers to FileSystemMapping. The WorkspaceSettingsTab no longer extends Settings.SettingsTab. For this reason, it creates the content element and header elements by itself now. It also reuses part of the css from the SettingsScreen in its workspaceSettingsTab.css. BUG=649837 R=dgozman Review-Url: https://codereview.chromium.org/2868543002 Cr-Commit-Position: refs/heads/master@{#469846} Committed: https://chromium.googlesource.com/chromium/src/+/142388b2f4c78a6e59851a1ffadd1169c1c76726

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -1041 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js View 3 chunks +9 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/EditFileSystemView.js View 12 chunks +23 lines, -23 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js View 10 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 4 chunks +12 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js View 1 chunk +156 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/editFileSystemView.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/module.json View 1 chunk +23 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css View 1 1 chunk +118 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 1 chunk +0 lines, -319 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/settings/editFileSystemView.css View 1 chunk +0 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 4 chunks +0 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 3 chunks +5 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +0 lines, -351 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/module.json View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
lushnikov
please, take a look
3 years, 7 months ago (2017-05-05 20:44:12 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2868543002/diff/1/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css File third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css (right): https://codereview.chromium.org/2868543002/diff/1/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css#newcode2 third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css:2: * Copyright (c) 2017 The Chromium Authors. All ...
3 years, 7 months ago (2017-05-05 23:01:57 UTC) #7
lushnikov
https://codereview.chromium.org/2868543002/diff/1/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css File third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css (right): https://codereview.chromium.org/2868543002/diff/1/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css#newcode2 third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css:2: * Copyright (c) 2017 The Chromium Authors. All rights ...
3 years, 7 months ago (2017-05-05 23:08:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868543002/20001
3 years, 7 months ago (2017-05-05 23:10:33 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 18:48:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/142388b2f4c78a6e59851a1ffadd...

Powered by Google App Engine
This is Rietveld 408576698