Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2868483002: Add dynamic declaration to CssRectangle width/height setters (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dynamic declaration to CssRectangle width/height setters BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/95930806c96e1fa894fd94a3a6f6997fc89e8e99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/src/CssRectangle.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
3 years, 7 months ago (2017-05-05 17:24:08 UTC) #2
Bob Nystrom
Awesome, thanks! LGTM.
3 years, 7 months ago (2017-05-05 17:35:37 UTC) #3
Alan Knight
3 years, 7 months ago (2017-05-05 20:34:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
95930806c96e1fa894fd94a3a6f6997fc89e8e99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698