Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 2868483002: Add dynamic declaration to CssRectangle width/height setters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 8f02998118df5db0e5ce942ae3a85e80a6a4ba09..e5866bb16e9421e9b65556667ea38a6c60ad46b6 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -20428,7 +20428,7 @@ class HttpRequest extends HttpRequestEventTarget {
void send([body_OR_data]) native;
/**
- * Sets the value of an HTTP requst header.
+ * Sets the value of an HTTP request header.
*
* This method should be called after the request is opened, but before
* the request is sent.
@@ -40652,7 +40652,7 @@ class _ContentCssRect extends CssRect {
* `height` function in jQuery and the calculated `height` CSS value,
* converted to a num in pixels.
*/
- set height(newHeight) {
+ set height(dynamic newHeight) {
if (newHeight is Dimension) {
if (newHeight.value < 0) newHeight = new Dimension.px(0);
_element.style.height = newHeight.toString();
@@ -40672,7 +40672,7 @@ class _ContentCssRect extends CssRect {
* and the calculated
* `width` CSS value, converted to a dimensionless num in pixels.
*/
- set width(newWidth) {
+ set width(dynamic newWidth) {
if (newWidth is Dimension) {
if (newWidth.value < 0) newWidth = new Dimension.px(0);
_element.style.width = newWidth.toString();
@@ -40832,7 +40832,7 @@ abstract class CssRect implements Rectangle<num> {
*
* Note that only the content height can actually be set via this method.
*/
- set height(newHeight) {
+ set height(dynamic newHeight) {
throw new UnsupportedError("Can only set height for content rect.");
}
@@ -40846,7 +40846,7 @@ abstract class CssRect implements Rectangle<num> {
*
* Note that only the content width can be set via this method.
*/
- set width(newWidth) {
+ set width(dynamic newWidth) {
throw new UnsupportedError("Can only set width for content rect.");
}
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698