Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2868463002: chromeos: enable MouseCursorEventFilter for mushrome (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: enable MouseCursorEventFilter for mushrome Now that mushrome creates a WindowTreeTreeHostManager it can create a MouseCursorEventFilter. Also updates test expectation as a bunch of tests were relying on this. BUG=714150, 706474 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2868463002 Cr-Commit-Position: refs/heads/master@{#469715} Committed: https://chromium.googlesource.com/chromium/src/+/a5888e81e68aff997094e675cccfe09c559d5f4b

Patch Set 1 #

Patch Set 2 : combine #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -333 lines) Patch
M ash/shell.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M testing/buildbot/filters/ash_mus_unittests.filter View 5 chunks +18 lines, -329 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 7 months ago (2017-05-05 15:07:36 UTC) #1
James Cook
LGTM https://codereview.chromium.org/2868463002/diff/20001/testing/buildbot/filters/ash_mus_unittests.filter File testing/buildbot/filters/ash_mus_unittests.filter (right): https://codereview.chromium.org/2868463002/diff/20001/testing/buildbot/filters/ash_mus_unittests.filter#newcode84 testing/buildbot/filters/ash_mus_unittests.filter:84: -PointerMetricsRecorderTest.DownEventPerInput Aside: There's something wrong with these tests ...
3 years, 7 months ago (2017-05-05 17:29:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868463002/20001
3 years, 7 months ago (2017-05-05 17:45:45 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:56:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a5888e81e68aff997094e675cccf...

Powered by Google App Engine
This is Rietveld 408576698