Ensure InfoBarManager is moved when preload tab is set as current tab.

ios/chrome/browser/ui/browser_view_controller.mm

Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index f9c0d98cb20e905a94d91ae4521d314f2dc2ea45..08e4a21a3f5403ff306690058bf85c6e0d69cdc6 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -4623,6 +4623,12 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
           withTab:(Tab*)newTab
           atIndex:(NSUInteger)index {
   [self uninstallDelegatesForTab:oldTab];
+
+  if (_infoBarContainer) {
+    infobars::InfoBarManager* infoBarManager = [newTab infoBarManager];
+    _infoBarContainer->ChangeInfoBarManager(infoBarManager);
+  }
+
   [self installDelegatesForTab:newTab];

[rohitrao (ping after 24h), 2017/05/09 14:40:17]

Does the new block of code need to come before |installDelegatesForTab|?  If so,
please add a comment explaining why.  If not, consider moving the new code to be
after this call, rather than in the middle of the uninstall/install dance.

[michaeldo, 2017/05/09 21:12:46]

I thought it did based on the other methods here, but no. There is not a
dependency, so I moved this new block to after the install call.

 
   // Add |newTab|'s view to the hierarchy if it's the current Tab.