[DMC #5.55] Add DocumentMarkerList::MarkerType()

third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp

Index: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp
index e814c1fafeb74c2ef676bf779f4cc6dd53be3f82..c3abe4d2e7dc26eb806fc3d54deb7ed1f06e7dd5 100644
--- a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp
@@ -10,10 +10,16 @@
 
 namespace blink {
 
+class SpellCheckMarkerListImplForTesting : public SpellCheckMarkerListImpl {

[yosin_UTC9, 2017/05/12 05:00:04]

We can use SpellingMarkerList and GrammarMakrerList here instead of introducing
test only class.

[rlanday, 2017/05/12 21:07:02]

Can you please clarify what you mean by "and"? Do you mean I should just use
SpellingMarkerListImpl, or that I should write a parameterized test that runs
all the test cases with both SpellingMarkerListImpl and GrammarMarkerListImpl,
or is there another option you want me to do?

[yosin_UTC9, 2017/05/15 04:03:04]

I propose having only "SpellingMarkerListImplTest.cpp" and
"GrammerMarkerListImpl.cpp":
 - SpellingMarkerListImpl: test all SpellingCheckerMakrerListImpl functions +
type checks
 - GrammarMakerListImpl: type checks + a comment mentions
"GrammerMarkerListImpl's member functions are implemented in
SpellCheckingMarkerListImpl and they are testing SpllingMarkerListImpl".

For simplicity and avoid test code duplication.

+  DocumentMarker::MarkerType MarkerType() const final {
+    return DocumentMarker::kSpelling;
+  }
+};
+
 class SpellCheckMarkerListImplTest : public ::testing::Test {
  protected:
   SpellCheckMarkerListImplTest()
-      : marker_list_(new SpellCheckMarkerListImpl()) {}
+      : marker_list_(new SpellCheckMarkerListImplForTesting()) {}
 
   DocumentMarker* CreateMarker(unsigned start_offset, unsigned end_offset) {
     return new DocumentMarker(DocumentMarker::kSpelling, start_offset,