third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h - Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

Issue 2868413002: [DMC #5.55] Add DocumentMarkerList::MarkerType() (Closed)

Patch Set: Add missing files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/markers/GrammarMarkerListImpl.h ('K') | « third_party/WebKit/Source/core/editing/markers/GrammarMarkerListImpl.cpp ('k') | third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImplTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

diff --git a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

index ff3de05d1391139db2c952726c3d1a0c40daf3cb..86e8b6341765d8089a5d7a338b169643c6d6968a 100644

--- a/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

+++ b/third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

@@ -9,9 +9,11 @@

namespace blink {

-// Implementation of DocumentMarkerList for Spelling/Grammar markers.

-// Markers with touching endpoints are merged on insert. Markers are kept sorted

-// by start offset in order to be able to do this efficiently.

+// Nearly-complete implementation of DocumentMarkerList for Spelling or Grammar

+// markers (subclassed by SpellingMarkerListImpl and GrammarMarkerListImpl to

+// implement the MarkerType() method). Markers with touching endpoints are

+// merged on insert. Markers are kept sorted by start offset in order to be able

+// to do this efficiently.

class CORE_EXPORT SpellCheckMarkerListImpl : public DocumentMarkerList {

public:

SpellCheckMarkerListImpl() = default;

yosin_UTC9 2017/05/12 05:00:04 nit: We should get move ctor of SpellCheckMarkerLi