Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868393006:
Use TaskScheduler instead of SequencedWorkerPool in media_resource_getter_impl.cc. (Closed)
DescriptionUse TaskScheduler instead of SequencedWorkerPool in media_resource_getter_impl.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=qinmin@chromium.org
Review-Url: https://codereview.chromium.org/2868393006
Cr-Commit-Position: refs/heads/master@{#472176}
Committed: https://chromium.googlesource.com/chromium/src/+/9af44404799be9d1b22b16e9e4da37ddf918b944
Patch Set 1 #Patch Set 2 : USER_VISIBLE #Messages
Total messages: 22 (12 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for all call sites and the base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. That may not be appropriate for your use case. Please verify that appropriate traits were used https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks. - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the shutdown behavior is not set explicitly (no base::TaskShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. What if the task priority is not set explicitly (no base::TaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dalecurtis@chromium.org changed reviewers: + tguilbert@chromium.org
=>tguilbert
LGTM
On 2017/05/15 21:43:16, tguilbert wrote: > LGTM Sorry, I retract that. NOT LGTM. From the definitions of the task priorities, base::TaskPriority::USER_VISIBLE would be more appropriate (this method returns is used to find and eventually display the duration of a video to users. This should not take an arbitrarily long amount of time to complete, or users might never be able to seek forward in the video, since seeking is clipped to the duration of the video).
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAnL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/16 12:33:08, fdoray wrote: > PTAnL LGTM!
On 2017/05/16 12:33:08, fdoray wrote: > PTAnL LGTM!
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494959206255490,
"parent_rev": "b26583c72c10f7aba88bcd087785be8afcd5ceae", "commit_rev":
"9af44404799be9d1b22b16e9e4da37ddf918b944"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in media_resource_getter_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=qinmin@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in media_resource_getter_impl.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=qinmin@chromium.org Review-Url: https://codereview.chromium.org/2868393006 Cr-Commit-Position: refs/heads/master@{#472176} Committed: https://chromium.googlesource.com/chromium/src/+/9af44404799be9d1b22b16e9e4da... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9af44404799be9d1b22b16e9e4da... |
