Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2868363002: printing: add native_drawing_context.h to printing sources list (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, wychen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: add native_drawing_context.h to printing sources list Headers files should also be listed in the sources list, but I missed this when I moved it from skia/. https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 https://groups.google.com/a/chromium.org/d/topic/chromium-dev/1kK45mVemBc/discussion BUG=661774 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2868363002 Cr-Commit-Position: refs/heads/master@{#470714} Committed: https://chromium.googlesource.com/chromium/src/+/c75e1fb9d386f28b9ec500c75181833fd0398b1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M printing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tfarina
3 years, 7 months ago (2017-05-10 17:00:03 UTC) #3
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-10 21:07:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868363002/1
3 years, 7 months ago (2017-05-10 21:09:14 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:21:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c75e1fb9d386f28b9ec500c75181...

Powered by Google App Engine
This is Rietveld 408576698