Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2868333005: Add CRWWebViewScrollViewProxy.decelerating (Closed)

Created:
3 years, 7 months ago by Hiroshi Ichikawa
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CRWWebViewScrollViewProxy.decelerating. It will be used in CWVScrollView. Review-Url: https://codereview.chromium.org/2868333005 Cr-Commit-Position: refs/heads/master@{#471168} Committed: https://chromium.googlesource.com/chromium/src/+/b8ae8d6a051956a6a627a9213b27d0ff486b3ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/web/public/web_state/ui/crw_web_view_scroll_view_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Hiroshi Ichikawa
3 years, 7 months ago (2017-05-12 01:12:27 UTC) #2
Eugene But (OOO till 7-30)
lgtm! Please update CL description to fit summary into one line (with 72 characters limit).
3 years, 7 months ago (2017-05-12 01:14:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868333005/1
3 years, 7 months ago (2017-05-12 01:17:49 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:40:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8ae8d6a051956a6a627a9213b27...

Powered by Google App Engine
This is Rietveld 408576698