Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2868323002: Remove the SVGImageElement::needs_loader_uri_update_ flag (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the SVGImageElement::needs_loader_uri_update_ flag Since xml:base is no longer a thing, there's no reason to delay the resource (image) load until the <image> element is in the document. Remove the flag and initiate resource loads a way resembling HTMLImageElement. This means a change in behavior, since it will now be possible get the load to start before the image is inserted into the document. The new behavior matches Gecko. Also clean up the code a bit, remove some unused includes and add a TODO for the document adopt case. BUG=720310 Review-Url: https://codereview.chromium.org/2868323002 Cr-Commit-Position: refs/heads/master@{#470898} Committed: https://chromium.googlesource.com/chromium/src/+/f15abc6c912c395a22c2656a39e9d2c46fba70c8

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Make test fail on 'error' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
A third_party/WebKit/LayoutTests/svg/dom/image-detached-load.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 6 chunks +18 lines, -34 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
fs
3 years, 7 months ago (2017-05-10 16:23:55 UTC) #8
Stephen Chennney
lgtm
3 years, 7 months ago (2017-05-10 17:13:05 UTC) #11
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-05-10 17:22:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868323002/40001
3 years, 7 months ago (2017-05-10 21:51:08 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450851)
3 years, 7 months ago (2017-05-11 00:35:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868323002/40001
3 years, 7 months ago (2017-05-11 10:12:39 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 10:18:41 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f15abc6c912c395a22c2656a39e9...

Powered by Google App Engine
This is Rietveld 408576698