Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2868213004: Add Windows and Mac network list implementation (Closed)

Created:
3 years, 7 months ago by btolsch
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org, mfoltz+watch_chromium.org, imcheng+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Windows and Mac network list implementation BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Mac compilation test #

Patch Set 4 : Add build_config.h for mac compilation #

Patch Set 5 : Fix LLADDR typo #

Patch Set 6 : Use unsigned dcheck value #

Patch Set 7 : Add possible mac implementation #

Patch Set 8 : Add missing mac wlan include #

Patch Set 9 : Sync with base patch, simplify mac/posix code sharing, add prints in test #

Patch Set 10 : Update Mac MaybeGetWifiSSID interface #

Patch Set 11 : Remove bad DCHECK #

Patch Set 12 : Update windows function/class naming #

Patch Set 13 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -21 lines) Patch
M chrome/browser/media/router/discovery/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/media/router/discovery/discovery_network_list_posix.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +30 lines, -19 lines 0 comments Download
M chrome/browser/media/router/discovery/discovery_network_list_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/media/router/discovery/discovery_network_list_wifi_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/media/router/discovery/discovery_network_list_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +209 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 41 (40 generated)
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 09:49:51 UTC) #6
This CL has an open dependency (Issue 2750453002 Patch 100001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

Powered by Google App Engine
This is Rietveld 408576698