Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create.

Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create.

BUG=705331
Review-Url: https://codereview.chromium.org/2868203002
Cr-Commit-Position: refs/heads/master@{#471660}
Committed: https://chromium.googlesource.com/chromium/src/+/d06138094fbdff17a1a18e4bc933bddf87732ab5

[pdyson, 2017-05-10 01:23:52]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:25:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:27:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:27:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[pdyson, 2017-05-11 06:00:27]

Description was changed from

==========
Replace Dialog.Delegate.Creation with Dialog.Delegate.Create.

BUG=705331
==========

to

==========
Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create.

BUG=705331
==========

[pdyson, 2017-05-12 00:58:37]

pdyson@chromium.org changed reviewers:
+ jwd@chromium.org, msw@chromium.org

[pdyson, 2017-05-12 00:58:52]

The CQ bit was checked by pdyson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 00:59:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-12 01:34:49]

lgtm with a q

https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11928: +  <obsolete>
What's the real deal with deprecating versus deleting these metrics? Do we
really need the old data to live in perpetuity? If someone [maliciously]
committed a million new metrics, would we never be able to remove those entries
from this file? It's mildly irritating how ridiculous this file is...

[commit-bot: I haz the power, 2017-05-12 02:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 02:37:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdyson, 2017-05-12 03:59:25]

On 2017/05/12 at 01:34:49, msw wrote:
> lgtm with a q
> 
>
https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:11928: +  <obsolete>
> What's the real deal with deprecating versus deleting these metrics? Do we
really need the old data to live in perpetuity? If someone [maliciously]
committed a million new metrics, would we never be able to remove those entries
from this file? It's mildly irritating how ridiculous this file is...

Jesse, this is a question for you.

[jwd, 2017-05-12 20:00:24]

lgtm

https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2868203002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:11928: +  <obsolete>
On 2017/05/12 01:34:49, msw wrote:
> What's the real deal with deprecating versus deleting these metrics? Do we
> really need the old data to live in perpetuity? If someone [maliciously]
> committed a million new metrics, would we never be able to remove those
entries
> from this file? It's mildly irritating how ridiculous this file is...

The reason to not delete is to preserve the mapping from histogram name to hash
so that old data is still readable (we treat this file as the ground truth). In
the case of the malicious or erroneous addition of a million metrics, we would
just remove them no big deal.

In this case, I'd almost suggest just deleting it, but it's made it to dev. If
we want to have a look at the dev data, we should keep it in, as obsolete. If
not, then I'm fine removing it entirely.

And note, the metrics team is aware of how ridiculous this file is, improving it
is always on our radar.

[pdyson, 2017-05-15 00:57:15]

The CQ bit was checked by pdyson@chromium.org

[commit-bot: I haz the power, 2017-05-15 00:57:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 02:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 02:07:32]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pdyson, 2017-05-15 03:31:40]

The CQ bit was checked by pdyson@chromium.org

[commit-bot: I haz the power, 2017-05-15 03:31:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 04:09:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494819100935590,
"parent_rev": "f4728d7d5a0884f5c40614fd9d29bf50c08a8a32", "commit_rev":
"d06138094fbdff17a1a18e4bc933bddf87732ab5"}

[commit-bot: I haz the power, 2017-05-15 04:09:15]

Description was changed from

==========
Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create.

BUG=705331
==========

to

==========
Replace Dialog.Delegate.Creation with Dialog.DialogDelegate.Create.

BUG=705331

Review-Url: https://codereview.chromium.org/2868203002
Cr-Commit-Position: refs/heads/master@{#471660}
Committed:
https://chromium.googlesource.com/chromium/src/+/d06138094fbdff17a1a18e4bc933...
==========

[commit-bot: I haz the power, 2017-05-15 04:09:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d06138094fbdff17a1a18e4bc933...