Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2868133002: Fix annotation of promoted parameters in Fasta inference tests. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix annotation of promoted parameters in Fasta inference tests. Previously, we only annotated "promotedType" for local variables; we need to annotate it for function parameters as well. Note that a few Fasta tests start failing as a result of this change, due to the fact that the Fasta type promotion/inference logic is not yet complete. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/12ee9643d90524e345471c847f22928e70d938bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -159 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +17 lines, -9 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 4 chunks +7 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_basic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_lub.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_nested_lambdas.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_for_each.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart View 1 chunk +13 lines, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_2.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_3.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_4.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_5.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_6.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_from_block.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional_2.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_generic_return.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 1 chunk +9 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_method_type.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +22 lines, -17 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_nested_generic_instantiation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_required.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop.dart View 4 chunks +9 lines, -11 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_multiple_levels_of_nesting.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/lambda_does_not_have_propagated_type_hint.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_double.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_int.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_t.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr1.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr1.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param_via_expr.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-09 20:52:46 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-09 20:56:46 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-09 20:59:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12ee9643d90524e345471c847f22928e70d938bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698