Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2293)

Unified Diff: pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart

Issue 2868133002: Fix annotation of promoted parameters in Fasta inference tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
diff --git a/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart b/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
index 8479fe81578ee026ae50a898774fbf3c51ccbebf..0388add8d1f198309ce71a5a4e049ab8e67c53c6 100644
--- a/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
+++ b/pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart
@@ -30,7 +30,7 @@ void main() {
return /*error:RETURN_OF_INVALID_TYPE*/ 3;
};
v = /*@returnType=String*/ <T>(/*@type=int*/ x) {
- return /*error:RETURN_OF_INVALID_TYPE*/ x;
+ return /*error:RETURN_OF_INVALID_TYPE*/ /*@promotedType=none*/ x;
};
}
{
@@ -56,15 +56,17 @@ void main() {
String int2String<T>(int x) => null;
String string2String<T>(String x) => null;
var /*@type=int2int(int) -> int*/ x = int2int;
- x = /*@returnType=int*/ <T>(/*@type=int*/ x) => x;
- x = /*@returnType=int*/ <T>(/*@type=int*/ x) => x + 1;
+ x = /*@returnType=int*/ <T>(/*@type=int*/ x) => /*@promotedType=none*/ x;
+ x = /*@returnType=int*/ <T>(/*@type=int*/ x) => /*@promotedType=none*/ x +
+ 1;
var /*@type=int2String(int) -> String*/ y = int2String;
y = /*info:INFERRED_TYPE_CLOSURE, error:INVALID_ASSIGNMENT*/ /*@returnType=int*/ <
T>(/*@type=int*/ x) =>
- x;
+ /*@promotedType=none*/ x;
y = /*@returnType=String*/ <
- T>(/*@type=int*/ x) => /*info:DYNAMIC_INVOKE, info:DYNAMIC_CAST*/ x.substring(3);
+ T>(/*@type=int*/ x) => /*info:DYNAMIC_INVOKE, info:DYNAMIC_CAST*/ /*@promotedType=none*/ x.substring(3);
var /*@type=string2String(String) -> String*/ z = string2String;
- z = /*@returnType=String*/ <T>(/*@type=String*/ x) => x.substring(3);
+ z = /*@returnType=String*/ <
+ T>(/*@type=String*/ x) => /*@promotedType=none*/ x.substring(3);
}
}

Powered by Google App Engine
This is Rietveld 408576698