Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(69)

Issue 2868093002: Add base::test::ScopedTaskEnvironment::RunUntilIdle(). (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add base::test::ScopedTaskEnvironment::RunUntilIdle(). This method runs tasks on the main thread until no main thread or TaskScheduler undelayed tasks remain. R=gab@chromium.org,robliao@chromium.org BUG=708584 Review-Url: https://codereview.chromium.org/2868093002 Cr-Commit-Position: refs/heads/master@{#470537} Committed: https://chromium.googlesource.com/chromium/src/+/f2b4d8358e465e016829cde71d11b736a105770d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -2 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/scoped_task_environment.h View 2 chunks +8 lines, -2 lines 1 comment Download
M base/test/scoped_task_environment.cc View 2 chunks +35 lines, -0 lines 1 comment Download
A base/test/scoped_task_environment_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
fdoray
PTAL
1 year, 10 months ago (2017-05-09 17:24:59 UTC) #2
gab
lgtm
1 year, 10 months ago (2017-05-09 18:49:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868093002/1
1 year, 10 months ago (2017-05-09 19:05:29 UTC) #7
robliao
lgtm % nits https://codereview.chromium.org/2868093002/diff/1/base/test/scoped_task_environment.cc File base/test/scoped_task_environment.cc (right): https://codereview.chromium.org/2868093002/diff/1/base/test/scoped_task_environment.cc#newcode24 base/test/scoped_task_environment.cc:24: ran_task_ = true; It would be ...
1 year, 10 months ago (2017-05-09 21:52:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/380246)
1 year, 10 months ago (2017-05-10 02:19:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868093002/1
1 year, 10 months ago (2017-05-10 10:17:16 UTC) #12
commit-bot: I haz the power
1 year, 10 months ago (2017-05-10 12:24:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2b4d8358e465e016829cde71d11...

Powered by Google App Engine
This is Rietveld 408576698