Add CHECK on session start for profile construction

Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the CHECK added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.

Review-Url: https://codereview.chromium.org/2868043002
Cr-Commit-Position: refs/heads/master@{#470524}
Committed: https://chromium.googlesource.com/chromium/src/+/f588c3bceb117e579068d1b4b3bb4153642d941d

[emaxx, 2017-05-09 14:23:12]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 14:23:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2017-05-09 15:49:12]

Description was changed from

==========
[!!TEMP!!] Add CHECK on session start for profile construction

BUG=719939
==========

to

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the check added at
https://crrev.com/2801993002).

BUG=719939
==========

[emaxx, 2017-05-09 15:53:17]

Description was changed from

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the check added at
https://crrev.com/2801993002).

BUG=719939
==========

to

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the check added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.
==========

[emaxx, 2017-05-09 15:53:34]

Description was changed from

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the check added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.
==========

to

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the CHECK added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.
==========

[emaxx, 2017-05-09 15:55:16]

emaxx@chromium.org changed reviewers:
+ msarda@chromium.org, xiyuan@chromium.org

[emaxx, 2017-05-09 15:55:16]

xiyuan@, msarda@: PTAL.
Does this whole approach look reasonable to you?

[commit-bot: I haz the power, 2017-05-09 16:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 16:00:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xiyuan, 2017-05-09 16:30:52]

lgtm

https://codereview.chromium.org/2868043002/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

https://codereview.chromium.org/2868043002/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:436:
CHECK(session_manager::SessionManager::Get()->HasSessionForAccountId(
nit: CHECK -> LOG_IF(FATAL, ...)

CHECK crashes without actually putting the message in log file.

[emaxx, 2017-05-09 17:11:46]

https://codereview.chromium.org/2868043002/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl.cc (right):

https://codereview.chromium.org/2868043002/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl.cc:436:
CHECK(session_manager::SessionManager::Get()->HasSessionForAccountId(
On 2017/05/09 16:30:52, xiyuan wrote:
> nit: CHECK -> LOG_IF(FATAL, ...)
> 
> CHECK crashes without actually putting the message in log file.

Done.

[emaxx, 2017-05-09 21:26:00]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:27:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 02:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:48:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[emaxx, 2017-05-10 03:22:07]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 03:22:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:45:29]

Dry run: This issue passed the CQ dry run.

[msarda, 2017-05-10 10:46:53]

LGTM.

[emaxx, 2017-05-10 10:48:52]

The CQ bit was checked by emaxx@chromium.org

[emaxx, 2017-05-10 10:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2868043002/#ps20001
(title: "CHECK -> LOG_IF(FATAL)")

[commit-bot: I haz the power, 2017-05-10 10:49:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494413332131840,
"parent_rev": "7f3fbfbed40625b2867df8d81bb3e9f9878b0620", "commit_rev":
"f588c3bceb117e579068d1b4b3bb4153642d941d"}

[commit-bot: I haz the power, 2017-05-10 11:15:15]

Description was changed from

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the CHECK added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.
==========

to

==========
Add CHECK on session start for profile construction

Fail fast from the profile construction when it's triggered without
starting a session first.

Crashing the browser is arguably a worth thing to do, as it prevents
running the browser in unexpected environment (which may lead to, for
instance, bypassing the managed policies).

Also this CHECK should provide the stack traces which are more likely to
point to the culprit code (as opposed to crashing at some later point
asynchronously - like e.g. on the CHECK added at
https://crrev.com/2801993002).

BUG=719939
TEST=existing browser tests;
    manual tests: normal login; Guest login; restart-after-crash.

Review-Url: https://codereview.chromium.org/2868043002
Cr-Commit-Position: refs/heads/master@{#470524}
Committed:
https://chromium.googlesource.com/chromium/src/+/f588c3bceb117e579068d1b4b3bb...
==========

[commit-bot: I haz the power, 2017-05-10 11:15:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f588c3bceb117e579068d1b4b3bb...