Issue 2867943002: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2867943002: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS. (Closed)

Created:
3 years, 7 months ago by mattm

Modified:
3 years, 7 months ago

Reviewers:
mattm

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS. Some folks are currently setting $TMPDIR to very long values on macOS, which causes socket name length issues when using $TMPDIR. R=mattm@chromium.org BUG=698759, 696803 Review-Url: https://codereview.chromium.org/2770753006 Cr-Commit-Position: refs/heads/master@{#461515} (cherry picked from commit 16abc4a0f8b419fe03dcfba8799cae52f28993b1) Review-Url: https://codereview.chromium.org/2867943002 . Cr-Commit-Position: refs/branch-heads/3029@{#823} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/fc1487fed94d1b5989094220dbbbb80c05841b51

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	base/files/file_util_mac.mm	View		2 chunks	+9 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/test_extension_dir.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

mattm

3 years, 7 months ago (2017-05-08 21:57:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fc1487fed94d1b5989094220dbbbb80c05841b51.